Enhanced the output with stats about JITClient specific Activity #9671
Conversation
EmanElsaban
force-pushed
the
new-branch
branch
3 times, most recently
from
a13258b
to
451c367
Compare
|
@mpirvu Hi Marius Can you please review my PR? Thank you |
| fprintf(stderr, "Level=%d\tnumComp=%d\n", i, _statsOptLevels[i]); | ||
| { | ||
| fprintf(stderr, "Level=%d\tnumComp=%d\tnumRemoteComp=%d\n", i, _statsOptLevels[i], _statsRemoteOptLevels[i]); | ||
| JITServerHelpers::printJITServerMsgStats(jitConfig); |
There was a problem hiding this comment.
This code prints the same message stats a few times (for each opt level). Here we want stats about the remote compilations, not about messages.
There was a problem hiding this comment.
Also, please change JITServerHelpers::printJITServerMsgStats(); to display total number of messages and average number of messages per compilation.
| #if defined(J9VM_OPT_JITSERVER) | ||
| for (int i = 0; i < JITServer::MessageType_ARRAYSIZE; ++i) | ||
| { | ||
| if (JITServerHelpers::serverMsgTypeCount[i] > 0) | ||
| { | ||
| totalMsgCount += JITServerHelpers::serverMsgTypeCount[i]; | ||
| } | ||
| } | ||
| #endif /* defined(J9VM_OPT_JITSERVER) */ | ||
| fprintf(stderr, "Total Number of messages:%d\tAverage number of messages per compilation: %f \n", totalMsgCount, totalMsgCount/float(totalNumRemoteCompilations)); |
There was a problem hiding this comment.
This piece of functionality is already done in HookedByTheJIT.cpp JitShutdown():
#if defined(J9VM_OPT_JITSERVER)
static char * isPrintJITServerMsgStats = feGetEnv("TR_PrintJITServerMsgStats");
if (isPrintJITServerMsgStats && compInfo->getPersistentInfo()->getRemoteCompilationMode() == JITServer::CLIENT)
JITServerHelpers::printJITServerMsgStats(jitConfig);
static char * isPrintJITServerCHTableStats = feGetEnv("TR_PrintJITServerCHTableStats");
if (isPrintJITServerCHTableStats)
JITServerHelpers::printJITServerCHTableStats(jitConfig, compInfo);
#endif
All you need to do is modify JITServerHelpers::printJITServerMsgStats so that it prints the number of total and average messages. The average can be computed by dividing the number of total messages to the number of messages of type compilationCode (every time a remote compilation occurs, the server will send a compilationCode message back at the end of the compilation.
| } | ||
| j9tty_printf(PORTLIB, "Total number of messages:%d\tAverage number of messages per compilation:%f\n", totalMsgCount, totalMsgCount/float(JITServerHelpers::serverMsgTypeCount[0])); |
There was a problem hiding this comment.
We need a check that JITServerHelpers::serverMsgTypeCount[0] is not 0. Otherwise the JVM will crash when doing division by 0
| if (_statsOptLevels[i] > 0) | ||
| fprintf(stderr, "Level=%d\tnumComp=%d\n", i, _statsOptLevels[i]); | ||
| fprintf(stderr, "Level=%d\tnumComp=%d\tnumRemoteComp=%d\n", i, _statsOptLevels[i], _statsRemoteOptLevels[i]); |
There was a problem hiding this comment.
This will not work on a build that does not have J9VM_OPT_JITSERVER defined because _statsRemoteOptLevels is going to be undefined.
| #if defined(J9VM_OPT_JITSERVER) | ||
| JITServerHelpers::printJITServerMsgStats(jitConfig); | ||
| #endif /* defined(J9VM_OPT_JITSERVER) */ |
There was a problem hiding this comment.
You don't have to call JITServerHelpers::printJITServerMsgStats(jitConfig); because it's already called in jitShutdown where it prints stats about messages
| { | ||
| if (_statsOptLevels[i] > 0) | ||
| fprintf(stderr, "Level=%d\tnumComp=%d\n", i, _statsOptLevels[i]); | ||
| #if defined(J9VM_OPT_JITSERVER) | ||
| if (_statsRemoteOptLevels[i] > 0) | ||
| fprintf(stderr, "numRemoteComp=%d\n", _statsRemoteOptLevels[i]); | ||
| #endif /* defined(J9VM_OPT_JITSERVER) */ | ||
|
|
||
| } |
There was a problem hiding this comment.
Somehow I think it looks nicer if the remote value appears on the same line, so maybe:
for (int i = 0; i < (int)numHotnessLevels; i++)
{
if (_statsOptLevels[i] > 0)
{
fprintf(stderr, "Level=%d\tnumComp=%d", i, _statsOptLevels[i]);
#if defined(J9VM_OPT_JITSERVER)
if (_statsRemoteOptLevels[i] > 0)
fprintf(stderr, "\tnumRemoteComp=%d", _statsRemoteOptLevels[i]);
#endif /* defined(J9VM_OPT_JITSERVER) */
fprintf(stderr, "\n");
}
}
Added how many compilations will be remote and how many messages were sent printed the total number of messages and the average number of messages per compilation issue: eclipse-openj9#9339 Signed-off-by: Eman Elsabban <eman.elsaban1@gmail.com>
|
jenkins test sanity plinuxjit,xlinuxjit jdk11 |
1 similar comment
|
jenkins test sanity plinuxjit,xlinuxjit jdk11 |
|
jenkins test sanity xlinuxjit jdk11 |
Added how many compilations will be remote and how many messages of each specific type were sent
issue: #9339
Signed-off-by: Eman Elsabban eman.elsaban1@gmail.com