Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete for build.properties #503

Closed
laeubi opened this issue Mar 11, 2023 · 3 comments · Fixed by #508
Closed

Autocomplete for build.properties #503

laeubi opened this issue Mar 11, 2023 · 3 comments · Fixed by #508
Labels
noteworthy Noteworthy feature

Comments

@laeubi
Copy link
Contributor

laeubi commented Mar 11, 2023

Currently there is no auto-completion for build.proeprties files in the source tab.
@gireeshpunathil
Copy link
Contributor

gireeshpunathil commented Mar 14, 2023 •
edited

@laeubi - @alshamams and I would like to investigate this. having a quick look at the auto-completion feature elsewhere, I see there are three parts to it:

  • auto-complete a partially written property
  • provide the specification of the property as a help text
  • provide a list of potential values to the fully qualified property

I wonder whether:

  • do all 3 make sense here?
  • should all 3 go in one PR?

@laeubi
Copy link
Contributor Author

laeubi commented Mar 14, 2023

Of course it is good to help the user as much as possible, so it depends a bit on the property itself, e.g. additional.bundles property might offer autocompletion for available bundles in the target state if the user asks for completion of the value.

As the very minimum "auto-complete a partially written properly" should be added, while others might be provided in separate PRs but this is at your own choice.

gireeshpunathil added a commit to gireeshpunathil/eclipse.pde that referenced this issue Mar 16, 2023
@gireeshpunathil
autocomplete for build.properties
d529048 
A rudimentary implementation of the
auto-complete feature for the build.properties
file editor for features, plugins and fragments.
Searches and auto-fills valid property names.

Fixes: eclipse-pde#503
@gireeshpunathil gireeshpunathil mentioned this issue Mar 16, 2023
Merged
gireeshpunathil added a commit to gireeshpunathil/eclipse.pde that referenced this issue Mar 16, 2023
@gireeshpunathil
autocomplete for build.properties
71ed9cb 
A rudimentary implementation of the
auto-complete feature for the build.properties
file editor for features, plugins and fragments.
Searches and auto-fills valid property names.

Fixes: eclipse-pde#503
@gireeshpunathil
Copy link
Contributor

@laeubi - PR raised; pls have a look when you get time. thanks!

@vik-chand vik-chand added the noteworthy Noteworthy feature label Mar 17, 2023
vogella pushed a commit that referenced this issue Mar 22, 2023
@gireeshpunathil @vogella
autocomplete for build.properties
3707839 
A rudimentary implementation of the
auto-complete feature for the build.properties
file editor for features, plugins and fragments.
Searches and auto-fills valid property names.

Fixes: #503
gireeshpunathil added a commit to gireeshpunathil/www.eclipse.org-eclipse-news that referenced this issue May 30, 2023
@gireeshpunathil
add N&N for PDE 503 and 527
6c61ba0 
Refs: eclipse-pde/eclipse.pde#503
Refs: eclipse-pde/eclipse.pde#527
@gireeshpunathil gireeshpunathil mentioned this issue May 30, 2023
Merged
lshanmug pushed a commit to eclipse-platform/www.eclipse.org-eclipse-news that referenced this issue May 30, 2023
@gireeshpunathil
add N&N for PDE 503 and 527 (#109)
01bfad0 
* add N&N for PDE 503 and 527

Refs: eclipse-pde/eclipse.pde#503
Refs: eclipse-pde/eclipse.pde#527

* fixup: address review comments

* fixup: add PR links for back-referencing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
noteworthy Noteworthy feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

autocomplete for build.properties gireeshpunathil/eclipse.pde
3 participants
@laeubi @gireeshpunathil @vik-chand