autocomplete for build.properties #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A rudimentary implementation of the auto-complete feature for the build.properties file editor for features, plugins and fragments. Searches and auto-fills valid property names. Fixes: eclipse-pde#503
gireeshpunathil
force-pushed
the
fix-503
branch
from
a6b831d
to
71ed9cb
Compare
laeubi
approved these changes
Mar 16, 2023
|
I'm adding @mickaelistria as a reviewer as he is more familiar with all the autocomplete/editor stuff and might has some improvements or hints. |
thanks @laeubi . auto-fill popup when content assist key is pressed on a half-baked property:
|
|
Very cool, thanks @gireeshpunathil |
HannesWell
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Thank you @gireeshpunathil for this, it is a handy addition and sorry for the late silence.
Although this is already merged I added some remarks below. Maybe you want to address them in a follow up?
.../org/eclipse/pde/internal/ui/editor/contentassist/BuildPropertiesContentAssistProcessor.java
Show resolved
Hide resolved
.../org/eclipse/pde/internal/ui/editor/contentassist/BuildPropertiesContentAssistProcessor.java
Show resolved
Hide resolved
.../org/eclipse/pde/internal/ui/editor/contentassist/BuildPropertiesContentAssistProcessor.java
Show resolved
Hide resolved
...ipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/build/BuildSourceViewerConfiguration.java
Show resolved
Hide resolved
gireeshpunathil
added a commit
to gireeshpunathil/eclipse.pde
that referenced
this pull request
Mar 23, 2023
a few review comments are included in this follow-up PR: - removed inheriting from ICompletionListener - hence removed completion listener registration (ICompletionListener.addCompletionListener) - usage of array creation shortcut - better string initialization - localization of fContentAssistantProcessor variable Refs: eclipse-pde#508
gireeshpunathil
added a commit
to gireeshpunathil/eclipse.pde
that referenced
this pull request
Mar 23, 2023
a few review comments are included in this follow-up PR: - removed inheriting from ICompletionListener - hence removed completion listener registration (ICompletionListener.addCompletionListener) - usage of array creation shortcut - better string initialization - localization of fContentAssistantProcessor variable Refs: eclipse-pde#508
@HannesWell - #529 , thanks in advance! |
HannesWell
pushed a commit
that referenced
this pull request
Mar 24, 2023
a few review comments are included in this follow-up PR: - removed inheriting from ICompletionListener - hence removed completion listener registration (ICompletionListener.addCompletionListener) - usage of array creation shortcut - better string initialization - localization of fContentAssistantProcessor variable Refs: #508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rudimentary implementation of the auto-complete feature for the build.properties file editor for features, plugins and fragments. Searches and auto-fills valid property names.
Pending items would be to handle corner cases (if any), provide a help text, provide potential suggestions for the values. But I prefer to handle one item at a time - I am still learning things!
Fixes: #503