make export dialog add button follow list selection #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vik-chand
requested changes
Apr 11, 2023
|
Also update to Copyright (c) 2005, 2023 |
|
@vik-chand -fixed both, thanks. |
There are potential race conditions that are happening between the dialog creation with empty list and the thread that populates the list and fires selection change events. An easy hack is to make sure the button is enabled whenever there are items in the list. This always works, as the default behavior of list makes sure that there is at least one item selected in a non-empty list. Fixes: eclipse-pde#534
vik-chand
force-pushed
the
export-package-dialog-add-button
branch
from
8a762aa
to
2e76150
Compare
vik-chand
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are potential race conditions that are happening between the dialog creation with empty list and the thread that populates the list and fires selection change events.
An easy hack is to make sure the button is enabled whenever there are items in the list. This always
works, as the default behavior of list makes sure
that there is at least one item selected in a
non-empty list.
Fixes: #534