Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make export dialog add button follow list selection #567

Merged
merged 2 commits into from
Apr 11, 2023
Merged

make export dialog add button follow list selection #567

merged 2 commits into from
Apr 11, 2023

Commits on Apr 11, 2023

  1. make export dialog add button follow list selection 

    There are potential race conditions that are happening
between the dialog creation with empty list and the
thread that populates the list and fires selection change
events.

An easy hack is to make sure the button is enabled
whenever there are items in the list. This always
works, as the default behavior of list makes sure
that there is at least one item selected in a
non-empty list.

Fixes: eclipse-pde#534
    @gireeshpunathil @vik-chand
    gireeshpunathil authored and vik-chand committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    374cbf5 View commit details
    Browse the repository at this point in the history

  2. fixup: address review comments

    @gireeshpunathil @vik-chand
    gireeshpunathil authored and vik-chand committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2e76150 View commit details
    Browse the repository at this point in the history