Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More details about 3rd-party libs #53

Merged

Conversation

mickaelistria
Copy link
Contributor

No description provided.

Copy link
Member

@SarikaSinha SarikaSinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also suggest how to handle these errors in any saved place like Build Path etc.
How can we get the actions automated?

@mickaelistria
Copy link
Contributor Author

We should also suggest how to handle these errors in any saved place like Build Path etc.

I don't think that the org.junit.... artifact names is usually saved in the Build Path. They either come from Maven, or from the .target or from the JUnit Classpath Container (which is dynamically re-computed on startup I believe). Can you please elaborate on the particular cases you think require further assistance?

@mickaelistria mickaelistria merged commit c674308 into eclipse-platform:master Jul 19, 2022
@SarikaSinha
Copy link
Member

We should also suggest how to handle these errors in any saved place like Build Path etc.

I don't think that the org.junit.... artifact names is usually saved in the Build Path. They either come from Maven, or from the .target or from the JUnit Classpath Container (which is dynamically re-computed on startup I believe). Can you please elaborate on the particular cases you think require further assistance?

This was not for junit in particular. As in future we will be doing for other jars as well.
For junit in particular I observed the issues coming after Export-Import as it saves the references.

@mickaelistria
Copy link
Contributor Author

The JUnit container specifically searches for org.junit bundle name in the installation see:

That's JUnit 4 and there are no OSGi alternative to Orbit's JUnit 4 . So this bundle is here to stay and was not removed from target nor feature.
In lines following the one you link, you can see that the org.junit.platform/jupiter bundles were changed.

@mickaelistria
Copy link
Contributor Author

For junit in particular I observed the issues coming after Export-Import as it saves the references.

Where are those references saved? Can you please add details about how to reproduce?

@SarikaSinha
Copy link
Member

For junit in particular I observed the issues coming after Export-Import as it saves the references.

Where are those references saved? Can you please add details about how to reproduce?

Sorry, Looks like a false alarm, Import was not building due to some other mismatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants