Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits merged by github have "GitHub <noreply@github.com>" committer #12

Closed
iloveeclipse opened this issue Feb 9, 2022 · 8 comments
Closed
Labels
wontfix This will not be worked on

Comments

@iloveeclipse
Copy link
Member

I see in Eclipse History that differently to gerrit, where the user that triggered "merge" was recorded as committer, few commits are pushed where the committer is "GitHub noreply@github.com":

Is this something we want / can / should configure globally and document in a policy, or is this responsibility of the individuals to do so, and if yes, hhow it should be done?

See git log --pretty=fuller command output:

git log --pretty=fuller -n 3
commit 02999245b760e4ddb79bd80343277e4828b40fab (HEAD -> master, origin/master)
Author:     Jayaprakash Arthanareeswaran <jarthana@in.ibm.com>
AuthorDate: Wed Feb 9 17:37:29 2022 +0530
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Feb 9 17:37:29 2022 +0530

    Create P-build for Java 18 #7 (#11)

commit 3dfa91e12b724ee6bdb4ab88e106645d81e37b12 (tag: Y20220209-0600)
Author:     Sarika Sinha <sarika.sinha@in.ibm.com>
AuthorDate: Wed Feb 9 14:27:28 2022 +0530
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Feb 9 14:27:28 2022 +0530

    #7 Debug  j18 (#10)
    
    * Update repositories_java18patch.txt
    
    * Update pom.xml
    
    * Update feature.xml

commit 004e0b224f8361da4c6ddf81c09e54aaa099d551
Author:     Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
AuthorDate: Wed Feb 9 13:58:53 2022 +0530
Commit:     GitHub <noreply@github.com>
CommitDate: Wed Feb 9 13:58:53 2022 +0530

    #7 jdt ui changes for p-build (#9)
    
    * Update repositories_java18patch.txt
    
    * Update feature.xml
    
    * Update pom.xml
@iloveeclipse iloveeclipse changed the title Commits merged by github has "GitHub <noreply@github.com>" committer Commits merged by github have "GitHub <noreply@github.com>" committer Feb 9, 2022
@mickaelistria
Copy link
Contributor

An alternative is to just let the committer field as it, unless it actually is a problem. But at the moment, I don't see what problem it does causes.

@akurtakov
Copy link
Member

@vogella is looking into a way to disable merge commits

@mickaelistria
Copy link
Contributor

I don't think it's caused by merge commits, it could be more the "Rebase and Merge" that causes it.

@mickaelistria
Copy link
Contributor

By the way, merge commits are disabled already.

@gzsombor
Copy link

AFAIK, this happens if you use "Squash commits..." button in Github, instead of the "Rebase and merge"

@SarikaSinha
Copy link
Member

I had created a local branch with first patch. Second patch was merged to the local branch. Later pull request was created with the local branch and merged. And then local branch was deleted.

@akurtakov
Copy link
Member

Is there anything worth keeping this one open still?

@akurtakov
Copy link
Member

Looks like there is no one still interested so I guess it's not an issue.

@iloveeclipse iloveeclipse added the wontfix This will not be worked on label Apr 20, 2022
MohananRahul pushed a commit to MohananRahul/eclipse.platform.releng.aggregator that referenced this issue Aug 11, 2023
…tform#12)

Add new fragment to platform feature.

Signed-off-by: Rolf Theunissen <rolf.theunissen@gmail.com>
deepika-u pushed a commit to deepika-u/eclipse.platform.releng.aggregator that referenced this issue Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants