Move I-build Windows tests to Java 17

[akurtakov]

Java 17 is used to run tests for Mac (only this version) and on Linux (together with other versions) . As windows resources are limited and Java 17 is the latest LTS JVM and the fact that all EPPs are shipped with Java 17 it makes sense for Windows tests to be run with Java 17 and not Java 11.

[akurtakov]

@sravanlakkimsetti Would you please outline what I have to do to achieve that?

[akurtakov]

Related to #755

[sravanlakkimsetti]

Here are the steps:

1. Raise a request with foundation to install java 17(temurin would suffice) on windows test machine
2. Update java links in the test job https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/JenkinsJobs/AutomatedTests/I_unit_win32_java11.groovy
3. Since test results publishing scripts parse the name of the job to list java version, you'll need to rename the test job to java 17 and update publishing scripts. The following scripts will need an update

• eclipse.platform.releng.aggregator/cje-production/scripts/publish.xml

  Line 187 in affbb3a

  value="ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-mac64-java17_macosx.cocoa.x86_64_17,ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-macM1-java17_macosx.cocoa.aarch64_17,ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-win32-java11_win32.win32.x86_64_11,ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-cen64-gtk3-java11_linux.gtk.x86_64_11,ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-cen64-gtk3-java17_linux.gtk.x86_64_17,ep${eclipseStreamMajor}${eclipseStreamMinor}${buildType}-unit-cen64-gtk3-java19_linux.gtk.x86_64_19" />

• https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/eclipse.platform.releng.tychoeclipsebuilder/eclipse/publishingFiles/staticDropFiles/testConfigs.php

[akurtakov]

Helpdesk issue opened https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2392

[akurtakov]

Helpdesk closed with

Temurin JDK 17 has been installed to C:\Program Files\Eclipse Adoptium\jdk-17.0.5.8-hotspot.

[akurtakov]

@sravanlakkimsetti Can you help with this one https://ci.eclipse.org/releng/job/AutomatedTests/job/ep427I-unit-win32-java17/1/console ?

[iloveeclipse]

I wonder if the directory where Java 11 was installed also had a space?

See -Djvm="C:\\Program Files\\Eclipse Adoptium\\jdk-17.0.5.8-hotspot\\bin\\java.exe" below and error Files\Eclipse was unexpected at this time.

C:\Users\genie.releng\workspace\AutomatedTests\ep427I-unit-win32-java17>ant -f getEBuilder.xml -Djava.io.tmpdir=C:\Users\genie.releng\workspace\AutomatedTests\ep427I-unit-win32-java17\tmp -Djvm="C:\\Program Files\\Eclipse Adoptium\\jdk-17.0.5.8-hotspot\\bin\\java.exe" -DbuildId=I20230112-0730  -DeclipseStream= "4.27.0" -DEBUILDER_HASH= "a9eb30da24c05b9a9eb1077ba3c199b63c559cdc"  -DdownloadURL="https://download.eclipse.org/eclipse/downloads/drops4/I20230112-0730" -Dargs=all -Dosgi.os=win32 -Dosgi.ws=win32 -Dosgi.arch=x86_64 -DtestSuite=all 

Files\Eclipse was unexpected at this time.

[iloveeclipse]

I wonder if the directory where Java 11 was installed also had a space?

Nope: see https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/pull/805/files
-Djvm="C:\\\\openjdk\\\\jdk-11\\\\bin\\\\java.exe"

[akurtakov]

@fredg02 can we get jdk-17 installed in a directory without space?

[iloveeclipse]

@akurtakov : why do we need -Djvm argument at all? Can you please try without? AFAIK ant can find Java in the JAVA_HOME, if it is defined properly. Or is this for some SDK tool inside started JVM?

[sravanlakkimsetti]

@sravanlakkimsetti Can you help with this one https://ci.eclipse.org/releng/job/AutomatedTests/job/ep427I-unit-win32-java17/1/console ?

When we have spaces in the paths we will need to use 8dot3 notation on windows. you get the name in 8dot3 notation using dir /x.

Now the problem is fixed but I found another issue here. Ant installed on the test machine is quite old. because of that I had to keep JAVA_HOME as java 11 and use -Djvm with java 17

[akurtakov]

Would you please request update of Ant?

[sravanlakkimsetti]

Would you please request update of Ant?

raised Upgrade ant installed on https://ci.eclipse.org/releng/computer/qa6xd-win11/