Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the java paths using 8dot3 notation #808

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

sravanlakkimsetti
Copy link
Member

tracked in #756

@sravanlakkimsetti sravanlakkimsetti linked an issue Jan 13, 2023 that may be closed by this pull request
@merks
Copy link
Contributor

merks commented Jan 13, 2023

Out of curiosity, I wonder if a path like C:\\PROGRA~1\\ECLIPS~1\\ could "change" if something else that starts with ECLIPS and came alphabetically before Eclipse Adoptium was installed?

@sravanlakkimsetti
Copy link
Member Author

sravanlakkimsetti commented Jan 13, 2023

Out of curiosity, I wonder if a path like C:\\PROGRA~1\\ECLIPS~1\\ could "change" if something else that starts with ECLIPS and came alphabetically before Eclipse Adoptium was installed?

it is based on time. if something else gets installed it will be ECLIPS~2. by the way you actually get these file names using dir /x. I used dir /x to get the actual names and then updated the script

I used https://ci.eclipse.org/releng/job/sravan-test-win/1/console for my test

@akurtakov
Copy link
Member

So ant runs with Java 11 but uses java 17 to actually execute the tests?

@merks
Copy link
Contributor

merks commented Jan 13, 2023

@sravanlakkimsetti I see. It would also work to use \\ to escape the single space (the same way that \\\\ is used to escape the single \ right?

@sravanlakkimsetti
Copy link
Member Author

So ant runs with Java 11 but uses java 17 to actually execute the tests?

yes that is correct

@sravanlakkimsetti
Copy link
Member Author

@sravanlakkimsetti I see. It would also work to use \\ to escape the single space (the same way that \\\\ is used to escape the single \ right?

In theory yes that should work but need to test on windows platform

@sravanlakkimsetti sravanlakkimsetti merged commit fc8e921 into master Jan 13, 2023
@sravanlakkimsetti sravanlakkimsetti deleted the sravanlakkimsetti-patch-1 branch January 13, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move I-build Windows tests to Java 17
3 participants