Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eclipse.platform.swt.binaries sub-module to reflect merge with eclipse.platform.swt #1700

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

HannesWell
Copy link
Member

With eclipse-platform/eclipse.platform.swt#956 the swt native binaries are stored in the eclipse.platform.swt repository using git-lfs. The eclipse.platform.swt.binaries repository is therefore obsolete.

Part of eclipse-platform/eclipse.platform.swt.binaries#2

.gitmodules Outdated Show resolved Hide resolved
@HannesWell
Copy link
Member Author

Jenkins build is not starting, probably due to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4124.

@HannesWell HannesWell force-pushed the remove-swt.binaries branch 5 times, most recently from 45e7920 to 146b781 Compare January 7, 2024 08:17
@HannesWell
Copy link
Member Author

HannesWell commented Jan 7, 2024

Great, as hoped, git clone automatically also performs a git-lfs pull if git-lfs is installed and the user-global or system .gitconfig has git-lfs' clean+smudge filters installed. Because the latter is the case for all centos based docker images since git-lfs has been installed via https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4119, no special adjustments for the I-builds are necessary and nothing more than this PR has to be done outside of the SWT repository.

Jenkinsfile Outdated Show resolved Hide resolved
With eclipse-platform/eclipse.platform.swt#956
the swt native binaries are stored in the eclipse.platform.swt
repository using git-lfs. The eclipse.platform.swt.binaries repository
is therefore obsolete.

Part of eclipse-platform/eclipse.platform.swt.binaries#2
@HannesWell HannesWell force-pushed the remove-swt.binaries branch 2 times, most recently from bac608f to 375f912 Compare January 8, 2024 18:08
@HannesWell HannesWell marked this pull request as ready for review January 8, 2024 18:12
@HannesWell HannesWell merged commit 0eee02a into eclipse-platform:master Jan 8, 2024
3 of 4 checks passed
@HannesWell HannesWell deleted the remove-swt.binaries branch January 8, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants