Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or remove references to obsolete eclipse.platform.swt.binaries repo #1721

Merged

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Jan 14, 2024

Fix paths that are still relevant and remove obsolete occurrences. Especially this fixes the provision of the SWT.zip files at the Eclipse download page.
Currently for example https://download.eclipse.org/eclipse/downloads/drops4/I20240108-1340/ only shows N/A for the size of the SWT.zips and if one tries to download them, the server says they are not available.

Part of eclipse-platform/eclipse.platform.swt.binaries#2
This should have be done in #1700, but I forgot it.

Fix paths that are still relevant and remove obsolete occurrences.
Especially this fixes the provision of the SWT.zip files at the Eclipse
download page.

Part of eclipse-platform/eclipse.platform.swt.binaries#2
@HannesWell
Copy link
Member Author

There are a few other hits for eclipse.platform.swt.binaries left in this repository, but I assume they are fine:

grafik

In general I wonder if it is correct to have pde_basedir.properties for jdt-doc?
Or is this just ignored?

@HannesWell
Copy link
Member Author

@akurtakov does this look good to you?

Copy link
Member

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@HannesWell HannesWell merged commit c18c2f6 into eclipse-platform:master Jan 14, 2024
4 checks passed
@HannesWell HannesWell deleted the swt.binaries-path-fixes branch January 14, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants