[test] add Test for expand of invisible TreeItem #901

[jukzi]

fails on GTK
eclipse-platform/eclipse.platform.ui#1331 (comment)

[github-actions]

Test Results

   299 files  ±0     299 suites  ±0   5m 32s ⏱️ -35s
 4 099 tests +1   4 090 ✅ ±0   8 💤 ±0  1 ❌ +1 
12 209 runs  +3  12 135 ✅ +2  73 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 985f5ea. ± Comparison against base commit bb3af98.

♻️ This comment has been updated with latest results.

[basilevs]

https://github.com/eclipse-platform/eclipse.platform.swt/actions/runs/7111071900/job/19358535698?pr=933

java.lang.ClassNotFoundException: com.atlassian.clover.recorder.junit.JUnitTestRunnerInterceptor
Error:  org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
Error:  java.lang.ClassNotFoundException: com.atlassian.clover.recorder.junit.JUnitTestRunnerInterceptor
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:631)
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1240)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1089)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:905)
Error:  	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)

[iloveeclipse]

java.lang.ClassNotFoundException: com.atlassian.clover.recorder.junit.JUnitTestRunnerInterceptor
Error:  org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
Error:  java.lang.ClassNotFoundException: com.atlassian.clover.recorder.junit.JUnitTestRunnerInterceptor
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:631)
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
Error:  	at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1240)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1089)
Error:  	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:905)
Error:  	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)

@basilevs : where do you see it, link?
Looks like this can cause SDK build fails too (SWT tests aren't executed ).

[basilevs]

where do you see it, link?

https://github.com/eclipse-platform/eclipse.platform.swt/actions/runs/7111071900/job/19358535698?pr=933

[jukzi]

That JUnitTestRunnerInterceptor was introduced with eclipse-platform/eclipse.platform.releng.aggregator#1630

Does it only make problem with swt? @akurtakov

[akurtakov]

I think what's missing is a dependency to this one being added in the surefire configuration (dependency tag), otherwise it would simply not be downloaded in builds and thus fail that way. TBH, I'm not 100% sure this is the correct way to support parametrized tests but as I don't have the time to investigate it further I don't want to spoil the party.
For the record I believe this config will fail many different builds.

[jukzi]

@SyntevoAlex here is a reproducer you asked for:
eclipse-platform/eclipse.platform.ui#1331 (comment)_

java.lang.AssertionError
	at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Tree.test_persistExpandStatusForInvisibleItems(Test_org_eclipse_swt_widgets_Tree.java:1219)

[SyntevoAlex]

Unfortunately my queue is more that full currently.
I hope to find time to have a look at this within a few weeks.

[SyntevoAlex]

@jukzi you might want to learn how to debug native code. I could give a few hints.

[jukzi]

@jukzi you might want to learn how to debug native code. I could give a few hints.

i would love to if i had the time - same issue here, i can't become expert in every field.

[jukzi]

i close this PR as there is currently not enough resources on SWT to fix the behaviour