Multiselection: lost after restart

[Wittmaxi]

How to reproduce

1. Press Ctrl+F
2. Enter a search term for a word that is contained multiple times in the file
3. Press "Select All"
4. Immediately close eclipse
5. Reopen eclipse

I am not sure if there are other way to select multiple words at once in eclipse. If that mechanism exists, it would be interesting to see if the same behaviour still applies.

Expected behaviour

After restarting eclipse, I expect the same - multiple - areas to still be part of my selection, instead of having one selection that spans from the first to the last selection.

Screenshots

After Step 3)

After step 5)

My setup

Eclipse IDE for RCP and RAP Developers (includes Incubating components)

Version: 2023-06 (4.28.0)
Build id: 20230608-1333

[jukzi]

@mickaelistria caused by implementing multiselection: 13e3e7a

@Wittmaxi If you need that feature please contribute a PR for saving multiselection

[mickaelistria]

It indeed looks like the editor only persists simple selections properly: block selection is discarded and multi-selection is joined (as described in this issue).
We would need a way to improve how the workspace persists the selections to better cover the various type. This would happen in a combination of changes in AbstractTextEditor#saveState and AbstractTextEditor#doRestoreState to support multiple selections. A PR would be welcome (note that backward compatibiity must be guaranteed, so doRestoreState would need to still be able to part legacy memento.