Fix Bug #1074 #1319
Merged
Fix Bug #1074 #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wittmaxi
commented
Nov 21, 2023
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java
Show resolved
Hide resolved
Wittmaxi
commented
Nov 21, 2023
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java
Show resolved
Hide resolved
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java
Outdated
Show resolved
Hide resolved
Wittmaxi
force-pushed
the
MW_MultiselectionLostAfterRestart
branch
from
435c9e5
to
42939fb
Compare
|
@mickaelistria I have addressed all of your concerns. After a bit of manual testing, I am more confident in this PR. |
mickaelistria
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Code is good to be merged, thanks.
However, can ayou please reformat the commit message. The usual best practice is to mention what's fixed in the commit header, then an optional details block and then the reference to the fixes issue.
For example here it could be
Restore editor MultiSelection on restart
Stores the multi-selection for the text editor in the memento; and restores it on restart.
Fixes https://github.com/eclipse-platform/eclipse.platform.ui/issues/1074
42939fb
to
87c7088
Compare
|
@mickaelistria I changed the message of the commit! |
mickaelistria
approved these changes
Nov 21, 2023
mickaelistria
force-pushed
the
MW_MultiselectionLostAfterRestart
branch
from
87c7088
to
b66c61a
Compare
Stores the multi-selection for the text editor in the memento; and restores it on restart. Fixes eclipse-platform#1074
HeikoKlare
force-pushed
the
MW_MultiselectionLostAfterRestart
branch
from
b66c61a
to
3c84b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Bug #1047:
Multiselection: lost after restartWhen saving it's state, an AbstractEditor will now consider MultiSelection.
This PR is a proposal for improvement and requires a few more iterations before release.
In particular, I would like to check: