Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter in Quick Access similar to VsCode #127

Closed
vogella opened this issue Jun 10, 2022 · 6 comments
Closed

Filter in Quick Access similar to VsCode #127

vogella opened this issue Jun 10, 2022 · 6 comments

Comments

@vogella
Copy link
Contributor

vogella commented Jun 10, 2022

In VsCode you can filter based on the category, e.g. Git: as in the following screenshot.

image

Would be super useful to have this also in Eclipse, e.g. for New: or View:
@vogella
Copy link
Contributor Author

vogella commented Jun 10, 2022

Adding a few people which showed interest into usability of Eclipse cc @jukzi @mickaelistria @marcushoepfner

@Bananeweizen
Copy link
Contributor

If you just want to filter for the different kinds of quick assist entries (as indicated by your "New: or View:" example), that already works, without the colon (e.g. type "view" and you get all views, but the number is still limited, so you have to use ctrl-3 again to see all).
Coming back to your original request, wouldn't it be easier to just add the category of commands to the text that is being matched, instead of inventing a different kind of query? That way just typing "git" would find any git command, independent of whether it has "git" in the label/title.

Bananeweizen added a commit to Bananeweizen/eclipse.platform.ui that referenced this issue Jun 16, 2022
@Bananeweizen
Match quick access input against command categories (eclipse-platform…
fa41e08 
…#127)

Quick access inputs like "Project", "Git" etc. should show all commands
of those categories, not only those that have these terms in their
labels.
Bananeweizen added a commit to Bananeweizen/eclipse.platform.ui that referenced this issue Jun 17, 2022
@Bananeweizen
Match quick access input against command categories (eclipse-platform…
2c0024e 
…#127)

Quick access inputs like "Project", "Git" etc. should show all commands
of those categories, not only those that have these terms in their
labels.

When testing, the difference can be seen by using "project" (or other
command category names) as quick access input. Without the change only
commands with "project" in their label are shown. With this change also
commands like "Build Clean - Discard old build state" are shown, which
don't contain "Project" in the label, but in are in that category.
@vogella vogella mentioned this issue Jun 17, 2022
Merged
@vogella
Copy link
Contributor Author

vogella commented Jun 17, 2022

If you just want to filter for the different kinds of quick assist entries (as indicated by your "New: or View:" example), that already works, without the colon (e.g. type "view" and you get all views, but the number is still limited, so you have to use ctrl-3 again to see all). Coming back to your original request, wouldn't it be easier to just add the category of commands to the text that is being matched, instead of inventing a different kind of query? That way just typing "git" would find any git command, independent of whether it has "git" in the label/title.

It is great to add additional elements but it would also be nice to be filter elements based on categories, I don't think this works at the moment:

image

@Bananeweizen
Copy link
Contributor

Yes, you still get the matches of the other categories, that's right. AFAIK there is currently no way to suppress matches, you will always get all matches.

vogella pushed a commit that referenced this issue Jun 17, 2022
@Bananeweizen @vogella
Match quick access input against command categories (#127)
9e7ffac 
Quick access inputs like "Project", "Git" etc. should show all commands
of those categories, not only those that have these terms in their
labels.

When testing, the difference can be seen by using "project" (or other
command category names) as quick access input. Without the change only
commands with "project" in their label are shown. With this change also
commands like "Build Clean - Discard old build state" are shown, which
don't contain "Project" in the label, but in are in that category.
@akurtakov
Copy link
Member

Is this one finished?

@mickaelistria
Copy link
Contributor

Would be super useful to have this also in Eclipse, e.g. for New: or View:

Do you have an example of 1 action or command user is currently having hard time to find and that would be more efficiently found with the proposed filters.

@vogella vogella closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vogella @Bananeweizen @mickaelistria @akurtakov