Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[find/replace dialog] remove Ringtone #1908

Closed
Wittmaxi opened this issue May 31, 2024 · 1 comment · Fixed by #1923
Closed

[find/replace dialog] remove Ringtone #1908

Wittmaxi opened this issue May 31, 2024 · 1 comment · Fixed by #1923
Labels
enhancement New feature or request

Comments

@Wittmaxi
Copy link
Contributor

Wittmaxi commented May 31, 2024 •
edited
Loading

This Issue Documents a review-comment from the find/replace overlay PR
which could not be addressed into the current proposal:
comment by @HeikoKlare and @vogella

In the PR for the Overlay, we decided to remove the Ringtone notifying of errors while searching, because it was perceived as annoying.
We should also remove it from the Dialog.
@Wittmaxi Wittmaxi added the enhancement New feature or request label May 31, 2024
@vogella
Copy link
Contributor

vogella commented May 31, 2024

+2 for this.

Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 3, 2024
@Wittmaxi
Find/Replace dialog, remove ring-tone eclipse-platform#1908
5056736 
Removes the beep which is issued after some unsuccessful operations in
the find/replace dialog.

fixes eclipse-platform#1908
@Wittmaxi Wittmaxi mentioned this issue Jun 3, 2024
Merged
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 4, 2024
@Wittmaxi
Find/Replace dialog, remove ring-tone eclipse-platform#1908
2e6a42d 
Removes the beep which is issued after some unsuccessful operations in
the find/replace dialog.

fixes eclipse-platform#1908
Wittmaxi added a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 4, 2024
@Wittmaxi
Find/Replace dialog, remove ring-tone eclipse-platform#1908
d749474 
Removes the beep which is issued after some unsuccessful operations in
the find/replace dialog.

fixes eclipse-platform#1908
HeikoKlare pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 5, 2024
@Wittmaxi @HeikoKlare
Find/Replace dialog, remove ring-tone eclipse-platform#1908
aabc5b5 
Removes the beep which is issued after some unsuccessful operations in
the find/replace dialog.

fixes eclipse-platform#1908
HeikoKlare pushed a commit to Wittmaxi/eclipse.platform.ui that referenced this issue Jun 6, 2024
@Wittmaxi @HeikoKlare
Find/Replace dialog, remove ring-tone eclipse-platform#1908
899a4be 
Removes the beep which is issued after some unsuccessful operations in
the find/replace dialog.

fixes eclipse-platform#1908
HeikoKlare pushed a commit that referenced this issue Jun 6, 2024
@Wittmaxi @HeikoKlare
Find/Replace dialog, remove ring-tone #1908
b1cc09d 
Removes the beep which is issued after some unsuccessful operations in
the find/replace dialog.

fixes #1908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Find/Replace dialog: remove ring-tone #1908 Wittmaxi/eclipse.platform.ui
2 participants
@vogella @Wittmaxi