Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find/Replace overlay: weird placement when unmaximizing #2059

Closed
Tracked by #2021
Wittmaxi opened this issue Jul 8, 2024 · 1 comment · Fixed by #2062
Closed
Tracked by #2021

Find/Replace overlay: weird placement when unmaximizing #2059

Wittmaxi opened this issue Jul 8, 2024 · 1 comment · Fixed by #2062
Labels
bug Something isn't working

Comments

@Wittmaxi
Copy link
Contributor

Wittmaxi commented Jul 8, 2024

Possibly regression after #1989

31
@Wittmaxi Wittmaxi added the bug Something isn't working label Jul 8, 2024
@Wittmaxi Wittmaxi mentioned this issue Jul 8, 2024
Open
61 tasks
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 8, 2024
@HeikoKlare
Do not unhide find/replace overlay of other editors when resizing ecl…
940956f 
…ipse-platform#2059

When multiple editors have an open find/replace overlay and a resize
event happens (e.g., by minimizing/maximizing the window), the overlays
of all editors are unhidden by accident. This was a result of
introducing hide functionality to the overlay for the case that the
target editor is too small to show the overlay, which conflicts with the
hiding functionality for the case that an editor is invisible.

This change streamlines the visibility-related functionality of the
find/replace overlay to be handled at a single place. In addition, all
repositioning and resizing events are only processed when an overlay is
actually visible. For invisible overlays, the repositioning and resizing
is now performed when they become visible again. In addition, a
unnecessary layouting and positionining operations when creating the
overlay are removed as the same operations are performed again when
opening the overlay anyway.

Fixes eclipse-platform#2059
@HeikoKlare HeikoKlare mentioned this issue Jul 8, 2024
Merged
@HeikoKlare
Copy link
Contributor

Yes, it is a regression from #1989. Thank you for finding and reporting it! I have proposed a fix in #2062.

HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Do not unhide find/replace overlay of other editors when resizing ecl…
e9f0314 
…ipse-platform#2059

When multiple editors have an open find/replace overlay and a resize
event happens (e.g., by minimizing/maximizing the window), the overlays
of all editors are unhidden by accident. This was a result of
introducing hide functionality to the overlay for the case that the
target editor is too small to show the overlay, which conflicts with the
hiding functionality for the case that an editor is invisible.

This change streamlines the visibility-related functionality of the
find/replace overlay to be handled at a single place. In addition, all
repositioning and resizing events are only processed when an overlay is
actually visible. For invisible overlays, the repositioning and resizing
is now performed when they become visible again. In addition, a
unnecessary layouting and positionining operations when creating the
overlay are removed as the same operations are performed again when
opening the overlay anyway.

Fixes eclipse-platform#2059
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Do not unhide find/replace overlay of other editors when resizing ecl…
dbab727 
…ipse-platform#2059

When multiple editors have an open find/replace overlay and a resize
event happens (e.g., by minimizing/maximizing the window), the overlays
of all editors are unhidden by accident. This was a result of
introducing hide functionality to the overlay for the case that the
target editor is too small to show the overlay, which conflicts with the
hiding functionality for the case that an editor is invisible.

This change streamlines the visibility-related functionality of the
find/replace overlay to be handled at a single place. In addition, all
repositioning and resizing events are only processed when an overlay is
actually visible. For invisible overlays, the repositioning and resizing
is now performed when they become visible again. In addition, a
unnecessary layouting and positionining operations when creating the
overlay are removed as the same operations are performed again when
opening the overlay anyway.

Fixes eclipse-platform#2059
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Do not unhide find/replace overlay of other editors when resizing ecl…
1e6af25 
…ipse-platform#2059

When multiple editors have an open find/replace overlay and a resize
event happens (e.g., by minimizing/maximizing the window), the overlays
of all editors are unhidden by accident. This was a result of
introducing hide functionality to the overlay for the case that the
target editor is too small to show the overlay, which conflicts with the
hiding functionality for the case that an editor is invisible.

This change streamlines the visibility-related functionality of the
find/replace overlay to be handled at a single place. In addition, all
repositioning and resizing events are only processed when an overlay is
actually visible. For invisible overlays, the repositioning and resizing
is now performed when they become visible again. In addition, a
unnecessary layouting and positionining operations when creating the
overlay are removed as the same operations are performed again when
opening the overlay anyway.

Fixes eclipse-platform#2059
HeikoKlare added a commit that referenced this issue Jul 9, 2024
@HeikoKlare
Do not unhide find/replace overlay of other editors when resizing #2059
21f5812 
When multiple editors have an open find/replace overlay and a resize
event happens (e.g., by minimizing/maximizing the window), the overlays
of all editors are unhidden by accident. This was a result of
introducing hide functionality to the overlay for the case that the
target editor is too small to show the overlay, which conflicts with the
hiding functionality for the case that an editor is invisible.

This change streamlines the visibility-related functionality of the
find/replace overlay to be handled at a single place. In addition, all
repositioning and resizing events are only processed when an overlay is
actually visible. For invisible overlays, the repositioning and resizing
is now performed when they become visible again. In addition, a
unnecessary layouting and positionining operations when creating the
overlay are removed as the same operations are performed again when
opening the overlay anyway.

Fixes #2059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@HeikoKlare @Wittmaxi