Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 578581 - MarkerSupportView custom groupings requires use of internal GroupsContribution #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eobrienPilz
Copy link
Contributor

This is a patch submission for the bugzilla issue here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=578581

The proposal is to have an API equivalent of the ContributionItem for Marker groups.
This will allow clients to create their own custom groupings.

Note: Creating the custom groupings was always possible but relied on referencing the internal GroupsContribution in the xml definition.

@mickaelistria
Copy link
Contributor

Can't CompoundContributionItem be used directly by clients?

@eobrienPilz
Copy link
Contributor Author

Can't CompoundContributionItem be used directly by clients?

Yes, but the classes to access marker grouping information are internal i.e. see GroupsContribution.getContributionItems().
It needs to access more that one internal class to populate the menu and execute the grouping action.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

Test Results

   921 files  ±0     921 suites  ±0   1h 9m 8s ⏱️ + 22m 45s
 7 512 tests ±0   7 361 ✅ ±0  151 💤 ±0  0 ❌ ±0 
23 688 runs  ±0  23 181 ✅ ±0  507 💤 ±0  0 ❌ ±0 

Results for commit e7a6202. ± Comparison against base commit d1fbc3c.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants