Avoid duplicate quick access entry (fixes #152) #153
Conversation
|
In my use-case reported in #152, I see that both entries are "Previous" so it seems like the issue is something we can better fix earlier without implementing a dedicated mitigation later. Maybe the Previous provider hosts a bug? |
|
|
||
| // if one category provides the same single entry like "previous", we can avoid | ||
| // showing the duplicate second list | ||
| if (res.size() >= 2 && res.get(0).size() == 1 && res.get(1).size() == 1 |
There was a problem hiding this comment.
I there a good way to increase clarity by extracting these boolean-statements into either a method or separate variables? For example, a
boolean isDuplicateCategory = ...
would help make the code speak for itself
There was a problem hiding this comment.
just wondering , what is the next action on this PR @Wittmaxi is the above suggestion a blocker ?
There was a problem hiding this comment.
@elsazac no, I was just wondering if the code-quality could be improved. I think this is fine
When you have used quick access previously, the dialog adds matching entries from "previous" at the top. Afterwards the same entries may appear from their "normal" provider (e.q. views, commands, ...). Since the logic of adding entries seems quite complex, this change fixes the duplicate entry by detecting the exact situation (same single entry in first and second provider list), and then removes the duplicate entry list.
akurtakov
force-pushed
the
avoid_duplicate_quickaccess
branch
from
090dfb3
to
344f1d1
Compare
Test Results 918 files + 1 918 suites +1 1h 13m 11s ⏱️ + 36m 56s For more details on these failures, see this check. Results for commit 344f1d1. ± Comparison against base commit 0de600a. |
When you have used quick access previously, the dialog adds matching
entries from "previous" at the top. Afterwards the same entries may
appear from their "normal" provider (e.q. views, commands, ...).
Since the logic of adding entries seems quite complex, this change fixes
the duplicate entry by detecting the exact situation (same single entry
in first and second provider list), and then removes the duplicate entry
list.