-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using DI for creating the ShowViewDialog #187
base: master
Are you sure you want to change the base?
Conversation
MWindow window = workbenchWindow.getService(MWindow.class); | ||
|
||
final ShowViewDialog dialog = new ShowViewDialog(shell, app, window, modelService, partService, ctx); | ||
private static void openOther(IWorkbenchWindow workbenchWindow, IEclipseContext ctx, EPartService partService) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not only IEclipseContext ctx
be required here then?
This is really useful and you can also use this to inject OSGi Services into UI components without using static access then! I wonder if it would make sense to even replace |
Glad you like it. Would be great if this API could be used more in Eclipse to reduce code.
I don't mind, getting the fitting IEclipseContext might be a challenge. Please open a new ticket / PR for this idea if you plan to work on this. |
I've seen some activity about more E4 lately and wondered whether you guys are interested in finishing this one? |
- add filtering to FileTreeContentProvider.elementsChanged() method so extraneous line elements are already filtered out of lineMatches set - fixes eclipse-platform#187
Instead of getting the parameters in our handler for calling the constructor of ShowViewDialog we can also use DI do to this, the resulting code is slightly shorter. No big win but a tiny move for using more DI in internal Eclipse code.
a101aaa
to
27b9bd4
Compare
Instead of getting the parameters in our handler for calling the
constructor of ShowViewDialog we can also use DI do to this, the
resulting code is slightly shorter. No big win but a tiny move for using
more DI in internal Eclipse code.