-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find/Replace overlay: disable search scope when leaving #1919 #1920
Find/Replace overlay: disable search scope when leaving #1919 #1920
Conversation
39e33c5
to
8b55690
Compare
Random failures are not related to this PR and documented in #751 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Only some minor comments on code style / naming / documentation.
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceOverlay.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceOverlay.java
Outdated
Show resolved
Hide resolved
....ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceOverlayFirstTimePopup.java
Outdated
Show resolved
Hide resolved
8b55690
to
4418163
Compare
…e-platform#1919 Replace the FocusListener with a ShellAdapter which will remove the search scope as soon as the overlay is left. The FocusListener didn't listen to the case where the focus is in the search bar and the search bar is left (and the overlay is left implicitly) fixes eclipse-platform#1919
4418163
to
f4a575c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. This looks good now. Let's wait for the build results and I expect that we can merge then.
Replace the FocusListener with a ShellAdapter which will remove the
search scope as soon as the overlay is left.
The FocusListener didn't listen to the case where the focus is in the
search bar and the search bar is left (and the overlay is left
implicitly)
fixes #1919