Find/Replace overlay: disable search scope when leaving #1919 #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wittmaxi
changed the title
Wittmaxi
changed the title
Wittmaxi
force-pushed
the
MW_disable_search_scope_when_leaving
branch
from
39e33c5
to
8b55690
Compare
|
Random failures are not related to this PR and documented in #751 |
HeikoKlare
reviewed
Jun 27, 2024
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceOverlay.java
Outdated
Show resolved
Hide resolved
...es/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceOverlay.java
Outdated
Show resolved
Hide resolved
....ui.workbench.texteditor/src/org/eclipse/ui/texteditor/FindReplaceOverlayFirstTimePopup.java
Outdated
Show resolved
Hide resolved
Wittmaxi
force-pushed
the
MW_disable_search_scope_when_leaving
branch
from
8b55690
to
4418163
Compare
…e-platform#1919 Replace the FocusListener with a ShellAdapter which will remove the search scope as soon as the overlay is left. The FocusListener didn't listen to the case where the focus is in the search bar and the search bar is left (and the overlay is left implicitly) fixes eclipse-platform#1919
Wittmaxi
force-pushed
the
MW_disable_search_scope_when_leaving
branch
from
4418163
to
f4a575c
Compare
HeikoKlare
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the FocusListener with a ShellAdapter which will remove the
search scope as soon as the overlay is left.
The FocusListener didn't listen to the case where the focus is in the
search bar and the search bar is left (and the overlay is left
implicitly)
fixes #1919