Remove deprecated method and constructor in PopupDialog #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs API filters I hope to finish #323 first. |
The method getPersistBounds() is removed from class org.eclipse.jface.dialogs.PopupDialog. Clients are encouraged to use the method getPersistLocation() or getPersistSize() instead. Also remove the deprecated constructor. Clients should use the not deprecated constructor. See bug 531913.
vogella
force-pushed
the
api-popup-removal
branch
from
52a3df0
to
5fe1064
Compare
|
Not sure why API check does not complain but lets believe it.... @HannesWell FYI, this is one of a deletions I usually do per release, something important but nice to reduce the code base from time to time. |
|
API removal update eclipse-platform/eclipse.platform.common#75 |
Yes, I also appreciate to get rid of unnecessary code. It just makes the code base simpler to understand if there is less to understand and therefore simplifies maintenance, even the code itself is not actively maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method getPersistBounds() is removed from class org.eclipse.jface.dialogs.PopupDialog. Clients are encouraged to use the method getPersistLocation() or getPersistSize() instead. Also remove the deprecated constructor. Clients should use the not deprecated constructor.
See bug 531913.