Databinding api deletion #323
Conversation
vogella
force-pushed
the
databinding-api-deletion
branch
from
2127a40
to
d4b0dba
Compare
vogella
force-pushed
the
databinding-api-deletion
branch
from
2a82264
to
5122e20
Compare
|
org.eclipse.ui.tests are missing... |
vogella
force-pushed
the
databinding-api-deletion
branch
from
5122e20
to
e9e1693
Compare
vogella
force-pushed
the
databinding-api-deletion
branch
from
e9e1693
to
61f03b2
Compare
vogella
force-pushed
the
databinding-api-deletion
branch
from
61f03b2
to
a89f2fd
Compare
vogella
force-pushed
the
databinding-api-deletion
branch
2 times, most recently
from
0c6d0f2
to
ac2dd46
Compare
|
Thanks @jensli I moved the documentation update to its own pull request and plan to merge this once the verifcation build is done. |
|
I have only had a rather quick look, but it seem good to me. |
|
I don't know how to balance the benefit of simplifying the code base by removing these old classes against the harm of breaking old unmaintained plugins that uses them. But it seems like you have a made a decision about that already! |
vogella
force-pushed
the
databinding-api-deletion
branch
2 times, most recently
from
9bbbb4a
to
eb71ce6
Compare
That was discussed multiple times and it's indeed not all black nor white and it may depend on the particular API. But in general, there is a process in place to minimize the risk. As for unmaintained plugins, well, they're unmaintained so it's a sign that no-one cares enough to keep them alive, so Platform project shouldn't really care either; there is no commitment for Platform that everything that has worked once with it will keep running forever (that would be crazy!). On the other end, there is a commitment from Platform that it does it best to remain sustainable and relevant, and getting rid of older API or improving code in general is acting towards that goal. |
In preparation of the following commit which performs the API deletion. For planned API deletions we increase the minor number, not the major number.
The following databinding classes will be removed. They have been obsolete since the databinding framework was transitioned to work with property classes in 2014. They are replaced by corresponding property factory classes. See bug 546820. org.eclipse.jface.databinding.viewers.ViewersObservables org.eclipse.jface.databinding.swt.SWTObservables org.eclipse.core.databinding.beans.BeansObservables org.eclipse.core.databinding.beans.PojoObservables org.eclipse.ui.databinding.WorkbenchObservables The following classes in the databinding bundles will be removed. They are replaced by typed factory classes with the same name, but in a sub-package that is called "typed". See bug 546822. org.eclipse.ui.databinding.WorkbenchProperties org.eclipse.core.databinding.beans.BeanProperties org.eclipse.core.databinding.beans.PojoProperties org.eclipse.jface.databinding.viewers.ViewerProperties org.eclipse.jface.databinding.swt.WidgetProperties Includes API filter for the affected plug-ins as we do not increase major version due to API deletion.
Removes the tests for the deleted API and updates multiple tests to use the new API. The test have not yet been generified (they were also not generified before). Change-Id: Ibd04c9a52c2752639cbcb731c04f2a3b248359fa
vogella
force-pushed
the
databinding-api-deletion
branch
from
eb71ce6
to
27d0fc8
Compare
|
Is this a new / known Tycho problems? Error: 5.816 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:3.0.0-SNAPSHOT:validate-classpath (default-validate-classpath) on project org.eclipse.core.commands: Execution default-validate-classpath of goal org.eclipse.tycho:tycho-compiler-plugin:3.0.0-SNAPSHOT:validate-classpath failed: Plugin org.eclipse.tycho:tycho-compiler-plugin:3.0.0-SNAPSHOT or one of its dependencies could not be resolved: Could not find artifact org.eclipse.jdt:ecj:jar:3.31.0-SNAPSHOT in tycho-snapshots (https://repo.eclipse.org/content/repositories/tycho-snapshots/) -> [Help 1] |
|
Rebuild worked fine, so I guess this was caused by eclipse-platform/eclipse.platform.releng.aggregator#581 which was reverted. Thanks @jensli for the help, I will push the Javadoc update via #341 |
|
Please check eclipse-pde/eclipse.pde#339 |
Needed due to changes in eclipse-platform/eclipse.platform.ui#323
Bugzilla ticket: https://bugs.eclipse.org/bugs/show_bug.cgi?id=546820