Migrate Ant UI performance tests to JUnit 5 #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The performance tests in org.eclipse.ant.tests.ui still rely on the JUnit 3 PerformanceTestCase. In addition, one test class is missing in the according test suite. * Migrates all Ant UI performance tests and test suites to JUnit 5 * Adds the missing OpenLaunchConfigurationDialogTest performance test to the performance test suite
Test Results 51 files + 15 51 suites +15 1h 2m 34s ⏱️ + 13m 59s Results for commit a94f4cf. ± Comparison against base commit cfb3c5f. This pull request removes 229 and adds 1259 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
akurtakov
approved these changes
Oct 26, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance tests in
org.eclipse.ant.tests.uistill rely on the JUnit 3PerformanceTestCase. In addition, one test class is missing in the according test suite.OpenLaunchConfigurationDialogTestperformance test to the performance test suiteSeparateVMTestsas part of the performance test suite is not yet migrated to JUnit 5, as it is derived from an ordinary Ant UI test, which is still based on JUnit 3. This will be migrated once the other, ordinary Ant UI tests are migrated to JUnit 4 / 5.Note that the performance tests are not executed in CI builds, so the change will probably not have any effect that is automatically validated.