Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Expression tests to JUnit 4 #754

Merged

Conversation

HeikoKlare
Copy link
Contributor

Most of the tests in org.eclipse.core.expressions.tests are still based on JUnit 3, i.e., implement the TestCase class. This change migrates the test classes and the according test suite to JUnit 4.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Test Results

       42 files  ±0         42 suites  ±0   59m 42s ⏱️ - 1m 35s
  3 778 tests ±0    3 775 ✔️ +  5    3 💤 ±0  0  -   5 
11 337 runs  ±0  11 310 ✔️ +15  27 💤 ±0  0  - 15 

Results for commit 10ed1e8. ± Comparison against base commit bf89859.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
org.eclipse.core.internal.expressions.tests.PropertyTesterTests ‑ testOdering
org.eclipse.core.internal.expressions.tests.PropertyTesterTests ‑ testOrdering

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review October 20, 2023 14:27
Most of the tests in org.eclipse.core.expressions.tests are still based
on JUnit 3, i.e., implement the TestCase class. This change migrates the
test classes and the according test suite to JUnit 4.
@HeikoKlare HeikoKlare merged commit 355490a into eclipse-platform:master Oct 26, 2023
16 checks passed
@HeikoKlare HeikoKlare deleted the expression-tests-junit4 branch October 26, 2023 17:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant