Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDFa support is being deprecated but is still required #4779

Closed
edwardsph opened this issue Sep 8, 2023 · 8 comments · Fixed by #4858 or #5069
Closed

RDFa support is being deprecated but is still required #4779

edwardsph opened this issue Sep 8, 2023 · 8 comments · Fixed by #4858 or #5069
Assignees
Labels
🐞 bug issue is a bug M3
Milestone

Comments

@edwardsph
Copy link
Contributor

Current Behavior

I'm raising this as a bug since the changes to Rio are going to break existing applications which are currently reporting usage of deprecated code.

It is currently possible to parse RDFa with Rio using https://github.com/semarglproject/semargl-rdf4j as a parser plugin:

ParserConfig parserConfig = new ParserConfig();
parserConfig.set(RDFaParserSettings.RDFA_COMPATIBILITY, RDFaVersion.RDFA_1_1);
Model model = Rio.parse(is, "https://example.org", RDFFormat.RDFA,
    parserConfig, SimpleValueFactory.getInstance(), new ParseErrorLogger());

See also: #512

The RDFa settings are now marked as deprecated, to be removed in 5.0 as it was assumed they were not in use: #4332.

Expected Behavior

The RDFa settings may not be used internally but they are used by plugins and deprecating them would prevent this. Please do not deprecate them.

Steps To Reproduce

No response

Version

4.3.6

Are you interested in contributing a solution yourself?

None

Anything else?

No response

@edwardsph edwardsph added the 🐞 bug issue is a bug label Sep 8, 2023
@hmottestad
Copy link
Contributor

This is just the RIO settings we are talking about right?

@edwardsph
Copy link
Contributor Author

I believe so. I think it was assumed that because RIO doesn't directly support RDFa then the settings aren't needed but that's forgetting that they are needed when using a 3rd party plugin.

@hmottestad
Copy link
Contributor

All the other RIO settings are being consolidated. Do you think the RIO settings for RDFa would still work if we change the namespace?

@edwardsph
Copy link
Contributor Author

I'd have to look at that but why not consolidate them with the others?

@hmottestad
Copy link
Contributor

Never mind. I had thought of the sail config.

The RIO settings aren't IRIs. We can move them to where the other RIO settings have been moved and add a comment referring to this issue here so they don't get deprecated again in the future.

@edwardsph
Copy link
Contributor Author

That would be perfect, thanks

@edwardsph
Copy link
Contributor Author

@hmottestad Please can you add this issue to the milestone list for 5.0.0 so it is not forgotten. Thanks

@hmottestad hmottestad added this to the 5.0.0 milestone Dec 15, 2023
@hmottestad hmottestad self-assigned this Dec 15, 2023
@hmottestad
Copy link
Contributor

If you have a chance it would be very kind if you could make a PR with the changes to remove the deprecation annotation and add a comment explaining that it's still in use referencing this issue.

edwardsph added a commit to edwardsph/rdf4j that referenced this issue Dec 18, 2023
This flag is not ready for deprecation as it is used by 3rd party plugins. It would be good to set up an alternative mechanism for providing this support before this is deprecated. See eclipse-rdf4j#4779 for details.
@hmottestad hmottestad assigned edwardsph and unassigned hmottestad Jan 16, 2024
@hmottestad hmottestad added the M3 label Jan 16, 2024
@hmottestad hmottestad modified the milestones: 5.0.0, 5.0.1 Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug issue is a bug M3
Projects
None yet
2 participants