-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-4779 Maintain RDFa support #4858
Conversation
This flag is not ready for deprecation as it is used by 3rd party plugins. It would be good to set up an alternative mechanism for providing this support before this is deprecated. See eclipse-rdf4j#4779 for details.
@edwardsph looks like you might need to sign the eclipse contributor agreement: https://github.com/eclipse-rdf4j/rdf4j/blob/main/CONTRIBUTING.md#eclipse-contributor-agreement |
@@ -26,7 +26,6 @@ public class RDFaParserSettings { | |||
* <p> | |||
* Defaults to {@link RDFaVersion#RDFA_1_0}. | |||
*/ | |||
@Deprecated(since = "4.3.0", forRemoval = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment explaining that these RDFa settings are in use by some users and referencing this issue: #4779
Please use a full link to the issue.
@@ -15,7 +15,6 @@ | |||
* | |||
* @author Peter Ansell | |||
*/ | |||
@Deprecated(since = "4.3.0", forRemoval = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment explaining that these RDFa settings are in use by some users and referencing this issue: #4779
Please use a full link to the issue.
Don't worry about the dash license issue, it's just a problem with the tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding comments into code to link to the issue
core/rio/api/src/main/java/org/eclipse/rdf4j/rio/helpers/RDFaParserSettings.java
Outdated
Show resolved
Hide resolved
core/rio/api/src/main/java/org/eclipse/rdf4j/rio/helpers/RDFaVersion.java
Show resolved
Hide resolved
Thanks @edwardsph :) |
@edwardsph could you run |
GitHub issue resolved: #4779
Briefly describe the changes proposed in this PR:
This flag is not ready for deprecation as it is used by 3rd party plugins. It would be good to set up an alternative mechanism for providing this support before this is deprecated. See #4779 for details.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)