Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4779 Maintain RDFa support #4858

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

edwardsph
Copy link
Contributor

GitHub issue resolved: #4779

Briefly describe the changes proposed in this PR:

This flag is not ready for deprecation as it is used by 3rd party plugins. It would be good to set up an alternative mechanism for providing this support before this is deprecated. See #4779 for details.


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

This flag is not ready for deprecation as it is used by 3rd party plugins. It would be good to set up an alternative mechanism for providing this support before this is deprecated. See eclipse-rdf4j#4779 for details.
@hmottestad
Copy link
Contributor

@edwardsph looks like you might need to sign the eclipse contributor agreement: https://github.com/eclipse-rdf4j/rdf4j/blob/main/CONTRIBUTING.md#eclipse-contributor-agreement

@@ -26,7 +26,6 @@ public class RDFaParserSettings {
* <p>
* Defaults to {@link RDFaVersion#RDFA_1_0}.
*/
@Deprecated(since = "4.3.0", forRemoval = true)
Copy link
Contributor

@hmottestad hmottestad Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment explaining that these RDFa settings are in use by some users and referencing this issue: #4779

Please use a full link to the issue.

@@ -15,7 +15,6 @@
*
* @author Peter Ansell
*/
@Deprecated(since = "4.3.0", forRemoval = true)
Copy link
Contributor

@hmottestad hmottestad Dec 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment explaining that these RDFa settings are in use by some users and referencing this issue: #4779

Please use a full link to the issue.

@hmottestad
Copy link
Contributor

Don't worry about the dash license issue, it's just a problem with the tool.

Copy link
Contributor Author

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding comments into code to link to the issue

@hmottestad
Copy link
Contributor

Adding comments into code to link to the issue

Thanks @edwardsph :)

@hmottestad
Copy link
Contributor

@edwardsph could you run mvn process-resources to format the code correctly and push a new commit?

@hmottestad hmottestad merged commit 0d74ce1 into eclipse-rdf4j:main Jan 23, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RDFa support is being deprecated but is still required
2 participants