Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to contribute a new diagram style and contribute a SVG node style #1316

Closed
lfasani opened this issue Aug 1, 2022 · 0 comments · Fixed by #1367
Closed

Add support to contribute a new diagram style and contribute a SVG node style #1316

lfasani opened this issue Aug 1, 2022 · 0 comments · Fixed by #1367
Assignees
@lfasani
Labels
difficulty: challenging package: diagrams type: feature request
Milestone
2022.11.0

Comments

@lfasani
Copy link
Contributor

lfasani commented Aug 1, 2022

Expected behavior

The aim is to contribute a new style that is not included in the sirius-component core
There will be two kind of changes:

  • enhance sirius-component to support contributed node style
  • contribute a new style based on a provided SVG

Cuttings backs

...

Potential side effects

...

Describe alternatives you've considered

...
@sbegaudeau sbegaudeau added this to the 2022.9.0 milestone Aug 1, 2022
@lfasani lfasani self-assigned this Aug 4, 2022
lfasani added a commit that referenced this issue Aug 4, 2022
@lfasani
WIP[1316][TODOcompartment layout ticket] Enhance the view model
afe9372 
Now there are two separated concept:
 * The node style description concept that tells how it is represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - SVGNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

TODO: check tests (test that are base on view models should be updated)

Bug: #1316
Bug: https://github.com/eclipse-sirius/sirius-components/issues/compartment layout ticket
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
@lfasani lfasani mentioned this issue Aug 4, 2022
Closed
39 tasks
lfasani added a commit that referenced this issue Aug 29, 2022
@lfasani
WIP[1316][TODOcompartment layout ticket] Enhance the view model
d88dde1 
Now there are two separated concept:
 * The node style description concept that tells how it is represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - SVGNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

TODO: check tests (test that are base on view models should be updated)

Bug: #1316
Bug: https://github.com/eclipse-sirius/sirius-components/issues/compartment layout ticket
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 12, 2022
@lfasani
[1316][1139] Enhance the view model
6d33e8c 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - SVGNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1139
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
@sbegaudeau sbegaudeau modified the milestones: 2022.9.0, 2022.11.0 Sep 13, 2022
lfasani added a commit that referenced this issue Sep 19, 2022
@lfasani
[1316][1139] Enhance the view model
334ac0a 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1139
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 19, 2022
@lfasani
[1316][1339] Enhance the view model
536df5a 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1339
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
@lfasani lfasani mentioned this issue Sep 19, 2022
Closed
27 tasks
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316] Support a new parametric SVG node style
813555d 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
@lfasani lfasani mentioned this issue Sep 23, 2022
Merged
39 tasks
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316] Support a new parametric SVG node style
98cfbe8 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316][1339] Enhance the view model
b35d9ed 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1339
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316] Support a new parametric SVG node style
6f0b58f 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
@gcoutable gcoutable linked a pull request Sep 23, 2022 that will close this issue
[1316] Support a new parametric SVG node style #1367
Merged
39 tasks
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316][1339] Enhance the view model
7d544a5 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1339
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316] Support a new parametric SVG node style
a23898e 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316][1339] Enhance the view model
6337dab 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1339
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316] Support a new parametric SVG node style
61b03de 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316][1339] Enhance the view model
d122376 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1339
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316] Support a new parametric SVG node style
f3b93d1 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316][1339] Enhance the view model
bccf825 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1339
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316] Support a new parametric SVG node style
dd87ee8 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316][1339] Enhance the view model
43964e6 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1339
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 23, 2022
@lfasani
[1316] Support a new parametric SVG node style
6fee411 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 25, 2022
@lfasani
[1316][1339] Enhance the view model
37dfa9c 
Now there are two separated concepts:
 * The node style description concept that tells how the node is
represented
 * The new concept of LayoutStrategyDescription that tells how the
children are layouted.

* Add new Styles
 - RectangularNodeStyleDescription
 - ImageNodeStyleDescription
 - IconLabelNodeStyleDescription
* Add a "childrenLayoutStrategy" feature to NodeDescription. There are
two implementations
 - FreeFormLayoutStrategyDescription
 - ListLayoutStrategyDescription

Bug: #1316
Bug: #1339
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 25, 2022
@lfasani
[1316] Support a new parametric SVG node style
2802901 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 26, 2022
@lfasani
[1316] Support a new parametric SVG node style
5ed9938 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 26, 2022
@lfasani
[1316] Support a new parametric SVG node style
9b7c752 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 26, 2022
@lfasani
[1316] Support a new parametric SVG node style
b687111 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
gcoutable pushed a commit that referenced this issue Sep 26, 2022
@lfasani @gcoutable
[1316] Support a new parametric SVG node style
361a661 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 27, 2022
@lfasani
[1316] Support a new parametric SVG node style
8353f2e 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
lfasani added a commit that referenced this issue Sep 27, 2022
@lfasani
[1316] Support a new parametric SVG node style
c5eb8c7 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
gcoutable pushed a commit that referenced this issue Sep 27, 2022
@lfasani @gcoutable
[1316] Support a new parametric SVG node style
7b9d93d 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
gcoutable pushed a commit that referenced this issue Sep 27, 2022
@lfasani @gcoutable
[1316] Support a new parametric SVG node style
d1028ff 
bug: #1316
Signed-off-by: Laurent Fasani <laurent.fasani@obeo.fr>
This was referenced Jan 23, 2023
Closed
Merged
pcdavid added a commit that referenced this issue Jan 23, 2023
@pcdavid
[1596] Add sample parametric SVG images to Sirius Web
986f03d 
Generic support for them was added in v2022.11.0 with #1316, but there
are no concrete examples in Sirius Web which makes it difficult to
test for.

Bug: #1596
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Jan 24, 2023
@pcdavid
[1596] Add sample parametric SVG images to Sirius Web
1d8aadc 
Generic support for them was added in v2022.11.0 with #1316, but there
are no concrete examples in Sirius Web which makes it difficult to
test for.

Bug: #1596
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jan 24, 2023
@pcdavid @sbegaudeau
[1596] Add sample parametric SVG images to Sirius Web
beaf614 
Generic support for them was added in v2022.11.0 with #1316, but there
are no concrete examples in Sirius Web which makes it difficult to
test for.

Bug: #1596
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Jan 24, 2023
@pcdavid @sbegaudeau
[1596] Add sample parametric SVG images to Sirius Web
80c1c92 
Generic support for them was added in v2022.11.0 with #1316, but there
are no concrete examples in Sirius Web which makes it difficult to
test for.

Bug: #1596
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfasani lfasani

Labels
difficulty: challenging package: diagrams type: feature request
Projects
None yet
Milestone
2022.11.0
Development

Successfully merging a pull request may close this issue.

[1316] Support a new parametric SVG node style eclipse-sirius/sirius-web
2 participants
@sbegaudeau @lfasani