Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Rectangular and Image nodes as the same kind of node #2480

Closed
Tracked by #2290
gcoutable opened this issue Oct 18, 2023 · 0 comments · Fixed by #2817
Closed
Tracked by #2290

Consider Rectangular and Image nodes as the same kind of node #2480

gcoutable opened this issue Oct 18, 2023 · 0 comments · Fixed by #2817

Comments

@gcoutable
Copy link
Contributor

gcoutable commented Oct 18, 2023

Remove GQLNode#type in ReactFlow and don't fetch this info in the GraphQL fragment nodeFragment

Feature parity between rectangular and image nodes

Combine both RectangularNode and ImageNode into a FreeFormNode in the frontend. In a similar fashion, we should thus have only a FreeFormNodeLayoutHandler. We may change the GraphQL API / Programmatic API later but this is not an issue for now. It will allow image nodes to have children and support the drop of semantic elements. The image could be connected to the node by using CSS background property.

See:

  • background-image: url("../img/blog.png") no-repeat center center;
  • background-size: contain;
  • background-repeat: no-repeat;

Test with an image node with child nodes to see the result

@gcoutable gcoutable added this to the 2023.12.0 milestone Oct 18, 2023
@sbegaudeau sbegaudeau self-assigned this Nov 28, 2023
@sbegaudeau sbegaudeau modified the milestones: 2023.12.0, 2024.1.0 Nov 28, 2023
@gcoutable gcoutable linked a pull request Dec 13, 2023 that will close this issue
39 tasks
sbegaudeau pushed a commit that referenced this issue Jan 4, 2024
Bug: #2480
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@gcoutable gcoutable removed this from the 2024.1.0 milestone Jan 26, 2024
@gcoutable gcoutable added this to the 2024.3.0 milestone Jan 26, 2024
frouene pushed a commit that referenced this issue Jan 31, 2024
Bug: #2480
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Jan 31, 2024
Bug: #2480
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Jan 31, 2024
Bug: #2480
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Feb 1, 2024
Bug: #2480
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Feb 13, 2024
Bug: #2480
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Feb 13, 2024
Bug: #2480
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Feb 13, 2024
Bug: #2480
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants