New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider Rectangular and Image nodes as the same kind of node #2480
Comments
6 tasks
gcoutable
added a commit
that referenced
this issue
Dec 13, 2023
gcoutable
added a commit
that referenced
this issue
Dec 13, 2023
39 tasks
gcoutable
added a commit
that referenced
this issue
Dec 13, 2023
gcoutable
added a commit
that referenced
this issue
Dec 13, 2023
gcoutable
added a commit
that referenced
this issue
Dec 13, 2023
gcoutable
added a commit
that referenced
this issue
Dec 13, 2023
gcoutable
added a commit
that referenced
this issue
Dec 13, 2023
gcoutable
added a commit
that referenced
this issue
Dec 14, 2023
gcoutable
added a commit
that referenced
this issue
Dec 14, 2023
gcoutable
added a commit
that referenced
this issue
Dec 14, 2023
gcoutable
added a commit
that referenced
this issue
Dec 14, 2023
gcoutable
added a commit
that referenced
this issue
Dec 15, 2023
gcoutable
added a commit
that referenced
this issue
Dec 15, 2023
sbegaudeau
pushed a commit
that referenced
this issue
Jan 4, 2024
sbegaudeau
pushed a commit
that referenced
this issue
Jan 4, 2024
sbegaudeau
pushed a commit
that referenced
this issue
Jan 4, 2024
sbegaudeau
pushed a commit
that referenced
this issue
Jan 4, 2024
sbegaudeau
pushed a commit
that referenced
this issue
Jan 4, 2024
Bug: #2480 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr> Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
frouene
pushed a commit
that referenced
this issue
Jan 31, 2024
Bug: #2480 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr> Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr> Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene
pushed a commit
that referenced
this issue
Jan 31, 2024
Bug: #2480 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr> Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr> Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene
pushed a commit
that referenced
this issue
Jan 31, 2024
Bug: #2480 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr> Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr> Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene
pushed a commit
that referenced
this issue
Feb 1, 2024
Bug: #2480 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr> Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr> Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau
pushed a commit
that referenced
this issue
Feb 13, 2024
Bug: #2480 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr> Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr> Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau
pushed a commit
that referenced
this issue
Feb 13, 2024
Bug: #2480 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr> Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr> Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau
pushed a commit
that referenced
this issue
Feb 13, 2024
Bug: #2480 Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr> Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr> Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Remove GQLNode#type in ReactFlow and don't fetch this info in the GraphQL fragment
nodeFragment
Feature parity between rectangular and image nodes
Combine both
RectangularNode
andImageNode
into aFreeFormNode
in the frontend. In a similar fashion, we should thus have only aFreeFormNodeLayoutHandler
. We may change the GraphQL API / Programmatic API later but this is not an issue for now. It will allow image nodes to have children and support the drop of semantic elements. The image could be connected to the node by using CSS background property.See:
background-image: url("../img/blog.png") no-repeat center center;
background-size: contain;
background-repeat: no-repeat;
Test with an image node with child nodes to see the result
The text was updated successfully, but these errors were encountered: