Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child's labels may exceed their container #2721

Closed
frouene opened this issue Dec 1, 2023 · 2 comments · Fixed by #2817
Closed

Child's labels may exceed their container #2721

frouene opened this issue Dec 1, 2023 · 2 comments · Fixed by #2817

Comments

@frouene
Copy link
Contributor

frouene commented Dec 1, 2023

Actual behavior

image

@gcoutable
Copy link
Contributor

It happens because we do not support outside labels.
The label of an image is considered inside the node to compute its size but is put outside the node.
Outside labels should be implemented in the next iteration.
However, I think I can produce a small fix for image nodes.

@gcoutable gcoutable self-assigned this Dec 1, 2023
@sbegaudeau sbegaudeau modified the milestones: 2023.12.0, 2024.1.0 Dec 5, 2023
@gcoutable
Copy link
Contributor

I was not able to produce the small fix since it was not working alone.
It has become a part of something greater.
This issue should be fixed when #2480 will be merged.

@frouene frouene added this to the 2024.3.0 milestone Feb 1, 2024
@frouene frouene self-assigned this Feb 1, 2024
frouene added a commit that referenced this issue Feb 1, 2024
Bug: #2721
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene linked a pull request Feb 1, 2024 that will close this issue
39 tasks
frouene added a commit that referenced this issue Feb 1, 2024
Bug: #2721
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Feb 1, 2024
Bug: #2721
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Feb 13, 2024
Bug: #2721
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Feb 13, 2024
Bug: #2721
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
sbegaudeau pushed a commit that referenced this issue Feb 13, 2024
Bug: #2721
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants