Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edges connected to the left or right side of a node are not properly centered #2608

Closed
pcdavid opened this issue Nov 21, 2023 · 0 comments · Fixed by #2603
Closed

Edges connected to the left or right side of a node are not properly centered #2608

pcdavid opened this issue Nov 21, 2023 · 0 comments · Fixed by #2603
Labels
package: diagrams type: enhancement
Milestone
2023.12.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Nov 21, 2023

See for example:

Capture d’écran du 2023-11-20 11-50-20

The edge should start from the middle of the right side of "DataSource 1" and end on the middle of the left side of "Composite Processor".

Currently they are at 1/3 of the side, because of the presence of an invisible "virtual" handle. That handle is required for internal/technical reasons, but should not be accounted for when placing the actual real edge handles.
@pcdavid pcdavid added this to the 2023.12.0 milestone Nov 21, 2023
pcdavid added a commit that referenced this issue Nov 21, 2023
@pcdavid
[2608] Improve the placement of handles on the left and right side of…
736d175 
… nodes

Make sure the "virtual" handles added after the real ones are not
considered by the flexbox on the container.

Bug: #2608
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Nov 21, 2023 that will close this issue
[2608] Improve the layout of edge handles on the left and right side of nodes #2603
Merged
39 tasks
pcdavid added a commit that referenced this issue Nov 21, 2023
@pcdavid
[2608] Improve the placement of handles on the left and right side of…
7d0ac8b 
… nodes

Make sure the "virtual" handles added after the real ones are not
considered by the flexbox on the container.

Bug: #2608
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 21, 2023
@pcdavid
[2608] Only create the virtual handles in ConnectionHandles
e810545 
Bug: #2608
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 21, 2023
@pcdavid
[2608] Only create the virtual handles in ConnectionHandles
858515c 
Bug: #2608
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 21, 2023
@pcdavid
[2608] Improve the placement of handles on the left and right side of…
eff883c 
… nodes

Make sure the "virtual" handles added after the real ones are not
considered by the flexbox on the container.

Bug: #2608
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Nov 21, 2023
@pcdavid
[2608] Improve the placement of handles on the left and right side of…
7a6a17e 
… nodes

Make sure the "virtual" handles added after the real ones are not
considered by the flexbox on the container.

Bug: #2608
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: diagrams type: enhancement
Projects
None yet
Milestone
2023.12.0
1 participant
@pcdavid