[2608] Improve the layout of edge handles on the left and right side of nodes #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcdavid
force-pushed
the
pcd/enh/handles-layout
branch
from
b07da96
to
736d175
Compare
pcdavid
changed the title
pcdavid
force-pushed
the
pcd/enh/handles-layout
branch
from
736d175
to
7d0ac8b
Compare
mcharfadi
reviewed
Nov 21, 2023
| @@ -102,6 +102,34 @@ export const ConnectionHandles = ({ connectionHandles }: ConnectionHandlesProps) | |||
| return !!handlesSelected.find((selectedHandle) => selectedHandle === connectionHandle.id); | |||
| }; | |||
|
|
|||
| const rightSideVirtualHandleId = `handle--source--${nodeId}--${ | |||
There was a problem hiding this comment.
const rightSideVirtualHandleId = handle--source--${nodeId}--${ connectionHandles.filter((connectionHandle) => connectionHandle.type === 'source').length + 1 };
There was a problem hiding this comment.
Same for the left one with target
There was a problem hiding this comment.
I've removed the second commit. It's not essential to the fix and causes unexpected problems.
|
The warning |
pcdavid
force-pushed
the
pcd/enh/handles-layout
branch
2 times, most recently
from
858515c
to
7d0ac8b
Compare
… nodes Make sure the "virtual" handles added after the real ones are not considered by the flexbox on the container. Bug: #2608 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
force-pushed
the
pcd/enh/handles-layout
branch
from
7d0ac8b
to
eff883c
Compare
mcharfadi
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request