Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When triggering a direct edit, the input should be placed at the same location as the label #2679

Closed
pcdavid opened this issue Nov 29, 2023 · 0 comments · Fixed by #2690
Closed

When triggering a direct edit, the input should be placed at the same location as the label #2679

pcdavid opened this issue Nov 29, 2023 · 0 comments · Fixed by #2690
Assignees
@pcdavid
Labels
package: diagrams type: enhancement
Milestone
2024.1.0

Comments

@pcdavid
Copy link
Member

pcdavid commented Nov 29, 2023

Currently the input field is always left-aligned, even though the labels are centered:

Capture.video.du.2023-11-29.10-32-34.webm
@pcdavid pcdavid mentioned this issue Nov 29, 2023
Merged
pcdavid added a commit that referenced this issue Nov 29, 2023
@pcdavid
[2679] Align the input element like the corresponding label
48a9684 
Bug: #2679
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Nov 29, 2023 that will close this issue
[2679] Align the input element like the corresponding label #2690
Merged
@sbegaudeau sbegaudeau added this to the 2024.1.0 milestone Dec 11, 2023
frouene pushed a commit that referenced this issue Dec 13, 2023
@pcdavid @frouene
[2679] Align the input element like the corresponding label
5c695d9 
Bug: #2679
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Dec 13, 2023
@pcdavid @frouene
[2679] Align the input element like the corresponding label
a3f9876 
Bug: #2679
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Dec 13, 2023
@pcdavid @frouene
[2679] Align the input element like the corresponding label
c4496d6 
Bug: #2679
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene pushed a commit that referenced this issue Dec 13, 2023
@pcdavid @frouene
[2679] Align the input element like the corresponding label
75fc792 
Bug: #2679
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Dec 14, 2023
@frouene
[2679] Align the input element like the corresponding label for edge
08a44f2 
Bug: #2679
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene added a commit that referenced this issue Dec 14, 2023
@frouene
[2679] Align the input element like the corresponding label for edge
ddb0829 
Bug: #2679
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
package: diagrams type: enhancement
Projects
None yet
Milestone
2024.1.0
Development

Successfully merging a pull request may close this issue.

[2679] Align the input element like the corresponding label eclipse-sirius/sirius-web
2 participants
@pcdavid @sbegaudeau