[2679] Align the input element like the corresponding label #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not ideal for small labels (like the "200" in the video), but better than the previous state where the input was left-aligned and much farther to the actual label's location. |
frouene
force-pushed
the
pcd/fix/direct-edit-input-position
branch
from
48a9684
to
5c695d9
Compare
frouene
approved these changes
Dec 13, 2023
frouene
force-pushed
the
pcd/fix/direct-edit-input-position
branch
from
5c695d9
to
a3f9876
Compare
Bug: #2679 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr> Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
frouene
force-pushed
the
pcd/fix/direct-edit-input-position
branch
from
a3f9876
to
c4496d6
Compare
|
The failed test is not related to the PR, I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #2679
Capture.video.du.2023-11-29.17-29-01.webm