Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display the contents of a Portal in the Representations view #2890

Closed
pcdavid opened this issue Jan 9, 2024 · 0 comments · Fixed by #2897
Closed

Display the contents of a Portal in the Representations view #2890

pcdavid opened this issue Jan 9, 2024 · 0 comments · Fixed by #2897
Assignees
@pcdavid
Labels
difficulty: medium package: forms package: portal type: feature request

Comments

@pcdavid
Copy link
Member

pcdavid commented Jan 9, 2024

When a Portal is selected, the Representations view should display a tree of all the representations embedded in the portal.
It should be a tree to also show the internals of any sub-portals.
Selecting a node in this tree should open the corresponding representation in "full mode".

Capture d’écran du 2024-01-09 10-20-50

Note that the Representations view on a semantic element shows a list of the representations attached to this element, where each item (representation) can be selected but also deleted. This is not possible when using a tree widget, where tree nodes do not support a delete action (or any other).
@pcdavid pcdavid added this to the 2024.1.0 milestone Jan 9, 2024
@pcdavid pcdavid self-assigned this Jan 9, 2024
@pcdavid pcdavid changed the title Display the contents of a Portal in the _Representations_ view Display the contents of a Portal in the Representations view Jan 9, 2024
pcdavid added a commit that referenced this issue Jan 9, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
b1057c3 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request Jan 9, 2024 that will close this issue
[2890] Display the contents of a Portal in the Representations view #2897
Merged
pcdavid added a commit that referenced this issue Jan 10, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
eb0bfce 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid mentioned this issue Jan 29, 2024
Merged
@sbegaudeau sbegaudeau removed this from the 2024.1.0 milestone Feb 1, 2024
This was referenced Feb 2, 2024
Open
Closed
pcdavid added a commit that referenced this issue Feb 7, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
e2ad7dd 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 7, 2024
@pcdavid
[2890] Update the new portal version before sending notifications
2b9eac5 
Rework the PortalEventProcessor and IPortalEventHandler so that:

* handlers only compute the response (which makes them simpler);
* the PortalEventProcessor handles the response by always
  updating/saving the new portal version (if there is one) before
  emiting notifications.

This ensures that "downstream" representations like the
Representations view see the correct, updated version of the Portal
when the notification triggers their own refresh.

This also centralizes the technical details about handling reactive
streams correctly (instead of counting on each and every handler to
e.g. always publish exactly one payload in all their code paths), and
allows for "middleware" handlers like the example CountingHandler to
be written once and apply to all handlers.

Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 7, 2024
@pcdavid
[2890] Update the new portal version before sending notifications
7c32aeb 
Rework the PortalEventProcessor and IPortalEventHandler so that:

* handlers only compute the response (which makes them simpler);
* the PortalEventProcessor handles the response by always
  updating/saving the new portal version (if there is one) before
  emiting notifications.

This ensures that "downstream" representations like the
Representations view see the correct, updated version of the Portal
when the notification triggers their own refresh.

This also centralizes the technical details about handling reactive
streams correctly (instead of counting on each and every handler to
e.g. always publish exactly one payload in all their code paths), and
allows for "middleware" handlers like the example CountingHandler to
be written once and apply to all handlers.

Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 8, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
a158753 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 8, 2024
@pcdavid
[2890] Update the new portal version before sending notifications
b88bd58 
Rework the PortalEventProcessor and IPortalEventHandler so that:

* handlers only compute the response (which makes them simpler);
* the PortalEventProcessor handles the response by always
  updating/saving the new portal version (if there is one) before
  emiting notifications.

This ensures that "downstream" representations like the
Representations view see the correct, updated version of the Portal
when the notification triggers their own refresh.

This also centralizes the technical details about handling reactive
streams correctly (instead of counting on each and every handler to
e.g. always publish exactly one payload in all their code paths), and
allows for "middleware" handlers like the example CountingHandler to
be written once and apply to all handlers.

Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 9, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
58d4e22 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 9, 2024
@pcdavid
[2890] Update the new portal version before sending notifications
9e6e4ca 
Rework the PortalEventProcessor and IPortalEventHandler so that:

* handlers only compute the response (which makes them simpler);
* the PortalEventProcessor handles the response by always
  updating/saving the new portal version (if there is one) before
  emiting notifications.

This ensures that "downstream" representations like the
Representations view see the correct, updated version of the Portal
when the notification triggers their own refresh.

This also centralizes the technical details about handling reactive
streams correctly (instead of counting on each and every handler to
e.g. always publish exactly one payload in all their code paths), and
allows for "middleware" handlers like the example CountingHandler to
be written once and apply to all handlers.

Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 9, 2024
@pcdavid
[2890] Add basic tests for the Representations view on portals
d3ca2a5 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 19, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
ea4f987 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 19, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
2c509aa 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 20, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
ac27203 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 20, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
2a1ea57 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 20, 2024
@pcdavid
[2890] Display the contents of a Portal in the Representations view
f2ca562 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 20, 2024
@pcdavid @sbegaudeau
[2890] Display the contents of a Portal in the Representations view
9f2ff9d 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 20, 2024
@pcdavid @sbegaudeau
[2890] Display the contents of a Portal in the Representations view
3b03cf3 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 20, 2024
@pcdavid @sbegaudeau
[2890] Display the contents of a Portal in the Representations view
42c7326 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 20, 2024
@pcdavid @sbegaudeau
[2890] Display the contents of a Portal in the Representations view
0663ee1 
Bug: #2890
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcdavid pcdavid

Labels
difficulty: medium package: forms package: portal type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[2890] Display the contents of a Portal in the Representations view eclipse-sirius/sirius-web
2 participants
@pcdavid @sbegaudeau