Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for representations in DefaultObjectService #3066

Closed
pcdavid opened this issue Feb 6, 2024 · 0 comments · Fixed by #3068
Closed

Add support for representations in DefaultObjectService #3066

pcdavid opened this issue Feb 6, 2024 · 0 comments · Fixed by #3068

Comments

@pcdavid
Copy link
Member

pcdavid commented Feb 6, 2024

I'm not entirely sure this is the right approach, but for #2890 I need to avoid the current behavior where a representation which uses another representation as a semantic element is considered dangling/obsolete as soon as it is created, and thus disposed immediately.

One approach outlined in #3023 would be to handle specifically this behavior in by changing how IDanglingRepresentationDeletionService works. This would fix this particular unwanted behavior but feels ad-hoc.

Another approach, implemented here, is to consider at the core of the framework, that representations can be considered as "objects" (as seen by IObjectService).
This would also fix the issue mentioned above, and remove the need for other "hacks" (i.e. in RepresentationsEventProcessorFactory, resolving the targetObjectId with either IObjectService or, explicitly, with IRepresentationSearchService).
Conceptually it also feels like a more "satisfying" approach as it removes a disctinction between "semantic elements" on one side and "representations" on the other.
However because it changes a rather fundamental assumption in the system, it can have some hard to predict side effects.

pcdavid added a commit that referenced this issue Feb 6, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 6, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 6, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 6, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid self-assigned this Feb 6, 2024
@pcdavid pcdavid added this to the 2024.3.0 milestone Feb 6, 2024
pcdavid added a commit that referenced this issue Feb 7, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Feb 9, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 12, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 12, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 12, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 12, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Feb 12, 2024
Bug: #3066
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment