Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default object images from model.edit/icons/full/obj16 are not used #866

Closed
4 tasks done
Tracked by #23
Gelio opened this issue Dec 4, 2021 · 2 comments
Closed
4 tasks done
Tracked by #23

Default object images from model.edit/icons/full/obj16 are not used #866

Gelio opened this issue Dec 4, 2021 · 2 comments

Comments

@Gelio
Copy link

Gelio commented Dec 4, 2021

  • I have checked that this bug has not yet been reported by someone else
  • I have checked that this bug appears on Chrome
  • I have specified the version :
  • other: 0.5.3
  • I have specified my environment :
  • Ubuntu 20.04 LTS

Screenshots

Sirius Desktop automatically generated icons for each object in the metamodel. They are in the .edit package, in the icons/full/obj16 directory. I have modified those icons. They are correctly shown in the model tree in Sirius Desktop:

image

When using that model in Sirius Web, it still loads the same default icons:

image

The URLs for those images returned in the treeEvent subscription are:

/api/images/icons/full/obj16/Item.gif#UnitCall

whereas they should be:

/api/images/icons/full/obj16/UnitCall.gif

as is also defined in the corresponding *ItemProvider class in the .edit package:

https://github.com/Gelio/CAL-web/blob/a8fc6c6860e810948ab42d354255149229a5bc81/backend/model/eu.balticlsc.model.CAL.edit/src-gen/eu/balticlsc/model/CAL/provider/UnitCallItemProvider.java#L168

Steps to reproduce

  1. Change the default icons generated for metamodel objects

Expected behavior

Those new icons are used in Sirius Web.

Actual behavior

The same old icon is used for objects in Sirius Web. The new images are not used. The URL contains the object name as a hash instead of the gif file name.

Gelio added a commit to Gelio/CAL-web that referenced this issue Dec 4, 2021
Customize the images used as icons for objects in the model tree.

The icons are only used in Sirius Desktop. Sirius Web does not load
them.
See eclipse-sirius/sirius-web#866

Related to #23
@pcdavid
Copy link
Member

pcdavid commented Dec 4, 2021

@Gelio
Copy link
Author

Gelio commented Dec 5, 2021

My bad! I can see the icons correctly after following your suggestion:

image

Thanks!

@Gelio Gelio closed this as completed Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants