Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2116] Add a modal to select a new value for single-valued references #2158

Merged
merged 4 commits into from
Jul 21, 2023
Merged

[2116] Add a modal to select a new value for single-valued references #2158

merged 4 commits into from
Jul 21, 2023

Conversation

pcdavid
Copy link
Member

@pcdavid pcdavid commented Jul 5, 2023 •
edited

simplescreenrecorder-2023-07-05_21.34.46.mp4

@pcdavid pcdavid added this to the 2023.8.0 milestone Jul 5, 2023
@pcdavid pcdavid linked an issue Jul 5, 2023 that may be closed by this pull request
Add a modal to select a new value for single-valued references #2116
Closed
@pcdavid pcdavid force-pushed the pcd/enh/single-ref-modal branch 2 times, most recently from 816e239 to be781e0 Compare July 12, 2023 13:47
@frouene frouene force-pushed the pcd/enh/single-ref-modal branch 4 times, most recently from d03e22d to dddfd0d Compare July 18, 2023 08:42
AxelRICHARD
AxelRICHARD requested changes Jul 18, 2023
View reviewed changes
.../org/eclipse/sirius/components/widget/reference/browser/ModelBrowserDescriptionProvider.java Outdated Show resolved Hide resolved
.../org/eclipse/sirius/components/widget/reference/browser/ModelBrowserDescriptionProvider.java Outdated Show resolved Hide resolved
.../org/eclipse/sirius/components/widget/reference/browser/ModelBrowserDescriptionProvider.java Outdated Show resolved Hide resolved
.../org/eclipse/sirius/components/widget/reference/browser/ModelBrowserDescriptionProvider.java Outdated Show resolved Hide resolved
.../org/eclipse/sirius/components/widget/reference/browser/ModelBrowserDescriptionProvider.java Outdated Show resolved Hide resolved
packages/forms/frontend/sirius-components-widget-reference/src/ReferencePropertySection.tsx Outdated Show resolved Hide resolved
packages/forms/frontend/sirius-components-widget-reference/src/ReferencePropertySection.tsx Outdated Show resolved Hide resolved
packages/forms/frontend/sirius-components-widget-reference/src/ReferencePropertySection.tsx Show resolved Hide resolved
packages/forms/frontend/sirius-components-widget-reference/src/modals/BrowseModal.tsx Outdated Show resolved Hide resolved
packages/sirius-web/frontend/sirius-web/src/index.tsx Outdated Show resolved Hide resolved
@frouene frouene force-pushed the pcd/enh/single-ref-modal branch 2 times, most recently from d44e758 to aac66d2 Compare July 19, 2023 08:54
AxelRICHARD
AxelRICHARD requested changes Jul 19, 2023
View reviewed changes
...lipse/sirius/components/widget/reference/datafetchers/ReferenceWidgetFeatureDataFetcher.java Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/FilterBar.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/FilterBar.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/FilterBar.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/FilterBar.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/Tree.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/Tree.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/Tree.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/Tree.types.ts Outdated Show resolved Hide resolved
packages/trees/frontend/sirius-components-trees/src/trees/FilterBar.tsx Outdated Show resolved Hide resolved
@frouene
Copy link
Contributor

frouene commented Jul 20, 2023

I've added cypress test.

This was linked to issues Jul 20, 2023
TreeView should be configurable to allow only single selection #2168
Closed
The tree representation used by the Reference widget modals should prune sub-trees with no compatible values #2171
Closed
Initialy reveal & select the current value(s) of a reference in the corresponding modals #2175
Closed
@pcdavid @frouene
[2116] Add modal to select new value for single-valued reference
36038f5 
Bug: #2126
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid @frouene
[2175] Reveal the current value(s) in the model browser
97ac716 
Bug: #2175
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid @frouene
[2171] Prune sub-trees with no compatible values
8af1b9d 
Bug: #2171
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid @frouene
[2168] Allow TreeView to disable multiple selection
28da8c3 
Bug: #2168
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@frouene frouene marked this pull request as ready for review July 20, 2023 15:20
@frouene frouene requested a review from sbegaudeau as a code owner July 20, 2023 15:20
@AxelRICHARD AxelRICHARD merged commit 4b580d0 into master Jul 21, 2023
4 checks passed
@AxelRICHARD AxelRICHARD deleted the pcd/enh/single-ref-modal branch July 21, 2023 06:37
This was linked to issues Jul 21, 2023
In the Reference widget modals, the filter bar should be initially visible #2170
Closed
Add a button to invoke "Expand All" on the reference widget's modals #2172
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD approved these changes

@frouene frouene frouene approved these changes

@sbegaudeau sbegaudeau Awaiting requested review from sbegaudeau sbegaudeau is a code owner

Assignees
No one assigned
Labels
pr: to review later priority: low
Projects
None yet
Milestone
2023.8.0
3 participants
@pcdavid @frouene @AxelRICHARD