Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ACC model - eliminate vehicle length from spacing margin #13755

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

robertalms
Copy link
Contributor

see #13681

@behrisch behrisch self-assigned this Sep 4, 2023
@behrisch
Copy link
Contributor

I suppose this is referring to equation 5 in https://pure.tudelft.nl/ws/portalfiles/portal/51734038/1_s2.0_S0968090X1830528X_main.pdf. You are right the L is superfluous and should not be in the code. But I have two questions: Why did you remove the "- 5". And do you have any idea what to do about the minGap here? I did not read the paper completely. Do they assume that such a concept exists or is it just part of the vehicle length?

@robertalms
Copy link
Contributor Author

robertalms commented Sep 20, 2023

  1. Sorry, removing the ' - 5' from the equation was a mistake on my side. Thanks for double checking!
  2. No, I don't think they account for a safe minimum distance as minGap. Neither in the original publication nor in this one is anything mentioned about something like this. So, I think it's indeed bumper to bumper distances. I guess, this is why they added this spacing margin later on.

I wouldn't account for the minGap here, additionally. We might get into a rabbit hole, if we look deeper into the gap issues with the model. So far I think, it's fairly validated for medium and higher speeds.

@behrisch
Copy link
Contributor

But the original reporter of #13681 tried to account for the minGap so I thought it would be fair to do so as well. gap2pred in the current code does not include the minGap so it is not bumper to bumper. But you are probably right If we allow the model to violate the minGap this is a sure way to more collisions because sumo already reports minGap violations as such

@robertalms
Copy link
Contributor Author

please also reopen #4551

@behrisch behrisch merged commit f768a45 into eclipse-sumo:main Sep 21, 2023
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants