Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfmodel ACC is creating collisions #4551

Open
namdre opened this issue Sep 7, 2018 · 3 comments · Fixed by #11778
Open

cfmodel ACC is creating collisions #4551

namdre opened this issue Sep 7, 2018 · 3 comments · Fixed by #11778
Assignees
@namdre
Labels
a:sumo bug c:carfollow

Comments

@namdre
Copy link
Contributor

namdre commented Sep 7, 2018

No description provided.

namdre added a commit that referenced this issue Sep 7, 2018
@namdre
giving more slack to ACC minGap observance. refs #4551
6f1a85c
namdre added a commit that referenced this issue Sep 7, 2018
@namdre
marking known bug refs #4551
81395bb
@namdre
Copy link
Contributor Author

namdre commented Sep 11, 2018

@leoluecken Can you check whether MSCFModel_ACC::finalizeSpeed() is needed? The current custom implementation does not make use of emergencyDecel. When using the default implementation, the number of collisions is greatly reduced.

namdre added a commit that referenced this issue Sep 12, 2018
@namdre
now using base class finalizeSpeed() in ACC model. This fixes issues …
23ade2b 
…with emergency braking and avoids many collisions. refs #4551
namdre added a commit that referenced this issue Sep 12, 2018
@namdre
patching expected results refs #21, refs #4551
4d58cd1
namdre added a commit that referenced this issue Sep 12, 2018
@namdre
adding emergency speed override refs #4551
457180a
namdre added a commit that referenced this issue Sep 12, 2018
@namdre
patching expected results refs #21, refs #4551
4055339
@namdre namdre assigned namdre and unassigned leoluecken Sep 12, 2018
@namdre namdre closed this as completed Sep 12, 2018
palvarezlopez pushed a commit that referenced this issue Sep 13, 2018
@namdre @palvarezlopez
now using base class finalizeSpeed() in ACC model. This fixes issues …
06a052e 
…with emergency braking and avoids many collisions. refs #4551
palvarezlopez pushed a commit that referenced this issue Sep 13, 2018
@namdre @palvarezlopez
patching expected results refs #21, refs #4551
2e01c2a
palvarezlopez pushed a commit that referenced this issue Sep 13, 2018
@namdre @palvarezlopez
adding emergency speed override refs #4551
70cbf33
palvarezlopez pushed a commit that referenced this issue Sep 13, 2018
@namdre @palvarezlopez
patching expected results refs #21, refs #4551
b3a244d
palvarezlopez pushed a commit that referenced this issue Sep 15, 2018
@namdre @palvarezlopez
patching expected results refs #21, refs #4551
32d9b4b
palvarezlopez pushed a commit that referenced this issue Sep 15, 2018
@namdre @palvarezlopez
patching expected results refs #21, refs #4551
099b78a
namdre added a commit that referenced this issue Sep 20, 2018
@namdre
fixing crash, introduced in [457180a]. refs #4551
a947ab7
@namdre
Copy link
Contributor Author

namdre commented Apr 29, 2022 •
edited
Loading

the test currently has collision

@namdre namdre reopened this Apr 29, 2022
@robertalms robertalms mentioned this issue Oct 7, 2022
Merged
robertalms added a commit to robertalms/sumo that referenced this issue Oct 10, 2022
@robertalms
Added references in respect to new spacing margin eclipse-sumo#11778 e…
da8cf20 
…clipse-sumo#4551
robertalms added a commit to robertalms/sumo that referenced this issue Oct 10, 2022
@robertalms
patching expected results refs eclipse-sumo#21, eclipse-sumo#11778, e…
763ca21 
…clipse-sumo#4551
namdre pushed a commit that referenced this issue Oct 11, 2022
@robertalms @namdre
Added references in respect to new spacing margin #11778 #4551
14d66e2
namdre pushed a commit that referenced this issue Oct 11, 2022
@robertalms @namdre
patching expected results refs #21, #11778, #4551
5d8aa5d
namdre added a commit that referenced this issue Oct 11, 2022
@namdre
patching expected results refs #21, #11778, #4551
7c0c5dc
robertalms added a commit to robertalms/sumo that referenced this issue Aug 29, 2023
@robertalms
patching test, known bug, refs eclipse-sumo#21 eclipse-sumo#13681 ecl…
d53ad57 
…ipse-sumo#4551
robertalms added a commit to robertalms/sumo that referenced this issue Sep 21, 2023
@robertalms
patching test, known bug, refs eclipse-sumo#21 eclipse-sumo#13681 ecl…
65b4dc6 
…ipse-sumo#4551
@robertalms robertalms mentioned this issue Sep 21, 2023
Merged
behrisch pushed a commit that referenced this issue Sep 21, 2023
@robertalms
Fix for ACC model - eliminate vehicle length from spacing margin (#13755
f768a45 
)

* Fix for ACC spacing margin #13681

* Fix in equation (5) for spacing margin #13681

* patching expected results refs #21 #13681

* patching test, known bug, refs #21 #13681 #4551
@behrisch behrisch reopened this Sep 21, 2023
@behrisch
Copy link
Contributor

The fix was unfortunately wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namdre namdre

Labels
a:sumo bug c:carfollow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added dynamic spacing margin to ACC model robertalms/sumo
3 participants
@behrisch @namdre @leoluecken