Url Encoded Component names are not searchable

[JSurf]

Description

Related Issues, Pull Requests:

#2115
#2043
#2042

Came across an issue with components containig "/" in the name which now cannot be searched. Same will be true for other special chars

Seems the mentioned merge request ( #2043 ) allows searching without encoding but now breaks encoded search strings due to the poor parsing of the query string. There is possibly a better solution to support unencoded parameters.

The new "parseQueryString" method looks very unsafe and could possibly break in many possible ways and also could also be a security risk ?

The "official" SW360 client implementation DOES urlencode the parameters and is now broken for package names with special chars.

How to reproduce

Use OSS Review toolkit and use the "upload-result-to-sw360" goal which uses the sw360 client library https://central.sonatype.com/artifact/org.eclipse.sw360/client
https://oss-review-toolkit.org/ort/docs/guides/sw360-integration
This breaks when components already exist on SW360

Another code snippet to test this:
Result: An empty array is printed
Expected: Details of the "org.apache.logging.log4j/log4j-core" should be printed

		SW360ConnectionFactory factory = new SW360ConnectionFactory();
		SW360Connection c = factory.newConnection(config);
		ComponentSearchParams searchParams = ComponentSearchParams.builder()
		        .withName("org.apache.logging.log4j/log4j-core")
		        .build();
		System.out.println(c.getComponentAdapter().search(searchParams));

Screenshots

If applicable, add screenshots to help explain your problem.

Versions

• Last commit id on master:
• Operating System (lsb_release -a):

Logs

Any logs (if any) generated in

SW360 logs

Logs generated under /var/log/sw360/sw360.log

Tomcat logs

Logs generated under /var/log/tomcat/error.log

[ag4ums]

@JSurf thanks for creating the issue, are you facing the same issue while searching releases as well?

[JSurf]

Yes,
System.out.println(c.getReleaseAdapter().getSparseReleaseByNameAndVersion("org.apache.logging.log4j/log4j-core", "2.22.1"));
also gives an empty result

[ag4ums]

@JSurf, you also mentioned that the client you are using is also broken due to the changes, could you point out the client.

[JSurf]

Client Code is here:
https://github.com/eclipse-sw360/sw360/tree/main/clients/client

[ag4ums]

@JSurf , can you please check if this PR #2359 is working fine for you?