Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component name search over endpoint with prefix ++ is returning an empty list #2042

Open
eldrin30 opened this issue Jul 12, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@eldrin30
Copy link
Contributor

Description

Component name search over endpoint with prefix ++ is returning an empty list

How to reproduce

Search for any component with name such as 'Angular++' over the rest endpoint

@nikkuma7
Copy link

Test Successful.
image

@JSurf
Copy link
Contributor

JSurf commented Feb 23, 2024

Came across a similar issue with packages containig "/" but the other way round.

Seems the mentioned merge request ( #2043 ) allows searching without encoding but now breaks encoded search strings due to the poor parsing of the query string. There is possibly a better solution to support unencoded parameters.

The new "parseQueryString" method looks very unsafe and could possibly break in many possible ways and also could also be a security risk ?

The "official" SW360 client implementation DOES urlencode the parameters and is now broken for package names with special chars.

@JSurf
Copy link
Contributor

JSurf commented Feb 23, 2024

Maybe the original bug request is just invalid. "+" sign is a special char in URLs, so this should propably be fixed on client side with proper URL encoding

@ag4ums
Copy link
Contributor

ag4ums commented Feb 23, 2024

Maybe the original bug request is just invalid. "+" sign is a special char in URLs, so this should probably be fixed on client side with proper URL encoding

@JSurf, Thank you for your detail analysis, Could you please create an issue for the same may be with an example to reproduce and tag the changes/PR those are causing this bug you faced.
Also tag the effected rest client in the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants