Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The component names with spaces are not searchable due to the conversion of space character to "%20" (URL Encoding) #2115

Closed
afsahsyeda opened this issue Sep 5, 2023 · 3 comments · Fixed by #2156
Closed

The component names with spaces are not searchable due to the conversion of space character to "%20" (URL Encoding) #2115

afsahsyeda opened this issue Sep 5, 2023 · 3 comments · Fixed by #2156
Assignees
@eldrin30
Labels
bug Something isn't working

Comments

@afsahsyeda
Copy link
Contributor

afsahsyeda commented Sep 5, 2023 •
edited
Loading

Description

Component names with space are not searchable via REST API after this PR #2043
@afsahsyeda afsahsyeda added the bug Something isn't working label Sep 5, 2023
@afsahsyeda
Copy link
Contributor Author

afsahsyeda commented Sep 11, 2023 •
edited
Loading

  • The component names with spaces are not searchable due to the conversion of space character to "%20" (URL Encoding).
  • Previously, the name query would get decoded and then searched over the DB. But now this functionality is removed. For ex: search queries like "?name=%40angular%2Fanimations" would be read as "?name=@angular/animations". Now, "%40angular%2Fanimations" is read as "%40angular%2Fanimations" only since decoding of characters is removed.
  • However, enabling support to decoding characters would affect special characters like "+" which are interpreted as space in Java URL Decoding.

@afsahsyeda afsahsyeda changed the title Url Encoded Component names are not searchable The component names with spaces are not searchable due to the conversion of space character to "%20" (URL Encoding) Oct 19, 2023
@afsahsyeda afsahsyeda mentioned this issue Oct 19, 2023
Merged
@JSurf
Copy link
Contributor

JSurf commented Feb 23, 2024

See also #2042 (comment)

any url encoded name is now broken, which breaks the official SW360 java client

@heliocastro
Copy link
Contributor

@ag4ums ^^^

@JSurf JSurf mentioned this issue Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eldrin30 eldrin30

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(REST):GET Component endpoint failing for names with space Siemens-Healthineers/sw360
4 participants
@heliocastro @JSurf @eldrin30 @afsahsyeda