repo: re-organize packages #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
force-pushed
the
mp/folders
branch
3 times, most recently
from
e62ae3a
to
4728f10
Compare
This was referenced Apr 28, 2021
alvsan09
reviewed
Apr 28, 2021
jfaltermeier
reviewed
May 4, 2021
There was a problem hiding this comment.
Thanks. the changes look good to me. I also tested on Linux and everything works fine.
One thing that is missing however is the documentation on the theia website:
This needs to be adjusted as well:
https://github.com/eclipse-theia/theia-website/blob/master/src/docs/blueprint_documentation.md
https://theia-ide.org/docs/blueprint_documentation/
paul-marechal
added a commit
to eclipse-theia/theia-website
that referenced
this pull request
May 4, 2021
See eclipse-theia/theia-blueprint#88 Signed-off-by: Paul Maréchal <marechap.info@gmail.com>
|
CI was red, I think I was missing |
paul-marechal
added a commit
to eclipse-theia/theia-website
that referenced
this pull request
May 4, 2021
See eclipse-theia/theia-blueprint#88 Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
|
Last CI build timed out, I tried to retrigger, unfortunately there is a merge conflict now. |
This makes the repository easier to read, and will prepare for when the browser version of Blueprint will be contributed. Moved `electron-app` into `applications/electron`, and Theia extensions under `theia-extensions/...` See `README.md` to see how the commands were updated. Whenever you expected to work on the electron application, you should now write like `yarn electron package` instead of `yarn package`. This simplifies the root package.json and accomodates for the upcoming browser application. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
jfaltermeier
approved these changes
May 17, 2021
paul-marechal
added a commit
to eclipse-theia/theia-website
that referenced
this pull request
May 17, 2021
See eclipse-theia/theia-blueprint#88 Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the repository easier to read, and will prepare for when the
browser version of Blueprint will be contributed.
Moved
electron-appintoapplications/electron, and Theia extensionsunder
theia-extensions/...See
README.mdto see how the commands were updated. Whenever youexpected to work on the electron application, you should now write like
yarn electron packageinstead ofyarn package. This simplifies theroot package.json and accomodates for the upcoming browser application.
Closes #87
How to test
Everything should work like before...
Review checklist
Reminder for reviewers