Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance measurement task #9

Merged

Conversation

planger
Copy link
Contributor

@planger planger commented Jul 21, 2023

With this change we introduce a separate Github action that periodically runs a performance measurement and collects values after each run via Theia's prometheus endpoint (/metrics). These values are kept persistent over time in the github pages.

Also we generate an initial report with graphs that plot the playwright execution time and the CPU seconds of each run.
This report will be available at:
https://eclipse-theia.github.io/theia-e2e-test-suite/performance

Contributed on behalf of STMicroelectronics

@planger planger requested a review from tortmayr July 21, 2023 13:06
With this change we introduce a separate Github action that periodically
runs a performance measurement and collects values after each run
via Theia's prometheus endpoint (`/metrics`).
These values are kept persistent over time in the github pages.

Also we generate an initial report with graphs that plot the playwright
execution time and the CPU seconds of each run.
This report will be available at:
https://eclipse-theia.github.io/theia-e2e-test-suite/performance

Contributed on behalf of STMicroelectronics
@planger planger force-pushed the add-performance-measurement-task branch from f43cb15 to 7e7a43c Compare July 21, 2023 13:54
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip. Very useful contribution!
The code & scripts look good to me and as far as I can see the performance workflow seems to run as expected. The publish steps however, can only be tested once this is merged into main.
LGTM! 👍🏼

@planger planger merged commit dc602dd into eclipse-theia:main Jul 21, 2023
1 check passed
@planger planger deleted the add-performance-measurement-task branch July 21, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants