Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Support TreeItemLabel in TreeItem #11148

Closed
Tracked by #9863
planger opened this issue May 12, 2022 · 1 comment · Fixed by #11288
Closed
Tracked by #9863

[vscode] Support TreeItemLabel in TreeItem #11148

planger opened this issue May 12, 2022 · 1 comment · Fixed by #11288
Assignees
Labels
vscode issues related to VSCode compatibility

Comments

@planger
Copy link
Contributor

planger commented May 12, 2022

Feature Description:

The interface TreeItemLabel can be used instead of plain strings for defining the TreeItem.label. In addition to the plain string label, TreeItemLabel can also specify highlights to indicate ranges in the label to highlight, see https://code.visualstudio.com/api/references/vscode-api#TreeItemLabel.

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label May 12, 2022
@lucas-koehler
Copy link
Contributor

I'm going to look into this :)

lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jun 13, 2022
* Add `TreeItemLabel` to theia.d.ts
* Align `TreeItem.label` with VS Code API to support `TreeItemLabel` as a value
* Extend plugin tree view implementation to support showing `TreeItemLabel.highlights`
  * Extend `TreeViewNode` to also extend `DecoratedTreeNode`
  * Set highlights in tree node's decoration data to displays them

Fixes eclipse-theia#11148

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jun 13, 2022
* Add `TreeItemLabel` to theia.d.ts
* Align `TreeItem.label` with VS Code API to support `TreeItemLabel` as a value
* Extend plugin tree view implementation to support showing `TreeItemLabel.highlights`
  * Extend `TreeViewNode` to also extend `DecoratedTreeNode`
  * Set highlights in tree node's decoration data to displays them

Fixes eclipse-theia#11148

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler added a commit to eclipsesource/theia that referenced this issue Jun 13, 2022
* Add `TreeItemLabel` to theia.d.ts
* Align `TreeItem.label` with VS Code API to support `TreeItemLabel` as a value
* Extend plugin tree view implementation to support showing `TreeItemLabel.highlights`
  * Extend `TreeViewNode` to also extend `DecoratedTreeNode`
  * Set highlights in tree node's decoration data to displays them

Fixes eclipse-theia#11148

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
msujew pushed a commit that referenced this issue Jun 13, 2022
…eeItem2` (#11288)

* vscode: Support `TreeItemLabel` in `TreeItem`

* Add `TreeItemLabel` to theia.d.ts
* Align `TreeItem.label` with VS Code API to support `TreeItemLabel` as a value
* Extend plugin tree view implementation to support showing `TreeItemLabel.highlights`
  * Extend `TreeViewNode` to also extend `DecoratedTreeNode`
  * Set highlights in tree node's decoration data to displays them

Fixes #11148

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>

* plugin: Remove obsolete, proposed `TreeItem2` and `TreeItemLabel`

Remove `TreeItem2` and `TreeItemLabel` from proposed plugin api because all properties are now supported and aligned with VS Code by `TreeItem` and `TreeItemLabel` in `theia.d.ts`

Contributed on behalf of STMicroelectronics

Signed-off-by: Lucas Koehler <lkoehler@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants