Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate "Save As" operation to plugin host #13689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msujew
Copy link
Member

@msujew msujew commented May 6, 2024

What it does

Closes #13688

Ensures that any new file created from a "Save As" operation correctly fires the onDidCreateFiles event in the plugin host. Also greatly simplifies the "Save As" operation logic.

How to test

  1. Download and install the test extension
  2. Use the save as operation to create a new file
  3. Ensure that a notification pops up (triggered by onDidCreateFiles)
  4. Ensure that the "Save As" operation behavior still works as expected

Review checklist

Reminder for reviewers

@msujew msujew added filesystem issues related to the filesystem plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels May 6, 2024
@msujew msujew force-pushed the msujew/save-as-plugin-host branch from 0a186dc to c999ba0 Compare May 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem issues related to the filesystem plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

Plugin host onDidCreateFiles isn't fired when running Save As command
1 participant