Propagate "Save As" operation to plugin host #13689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
filesystem
msujew
force-pushed
the
msujew/save-as-plugin-host
branch
from
0a186dc
to
c999ba0
Compare
msujew
force-pushed
the
msujew/save-as-plugin-host
branch
from
c999ba0
to
b71a8c4
Compare
martin-fleck-at
requested changes
Jun 17, 2024
There was a problem hiding this comment.
Hi @msujew, thank you very much for your change! I do have a few questions and concerns but overall it seems to work as advertised.
martin-fleck-at
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
@msujew Thank you for the quick feedback! With the latest changes, I think we are good to go. Everything works as expected and the documentation was adjusted where necessary. Great work!
msujew
force-pushed
the
msujew/save-as-plugin-host
branch
from
1435ad3
to
97f91d5
Compare
|
@msujew I think we can merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #13688
Ensures that any new file created from a "Save As" operation correctly fires the
onDidCreateFilesevent in the plugin host. Also greatly simplifies the "Save As" operation logic.How to test
onDidCreateFiles)Review checklist
Reminder for reviewers