Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin host onDidCreateFiles isn't fired when running Save As command #13688

Closed
msujew opened this issue May 6, 2024 · 0 comments · Fixed by #13689
Closed

Plugin host onDidCreateFiles isn't fired when running Save As command #13688

msujew opened this issue May 6, 2024 · 0 comments · Fixed by #13689
Labels
bug bugs found in the application filesystem issues related to the filesystem plug-in system issues related to the plug-in system
Milestone

Comments

@msujew
Copy link
Member

msujew commented May 6, 2024

Bug Description:

I've noticed this while looking into #13687. The vscode.workspace.onDidCreateFiles event isn't fired when a new file is created in the workspace as part of a "Save As" operation.

Consumers (such as language servers) therefore aren't notified about these files.

Steps to Reproduce:

  1. Set a breakpoint here.
  2. Use the New File command.
  3. Save the untitled resource.
  4. The breakpoint isn't hit, the event doesn't fire.

Additional Information

  • Theia Version: 1.49.0
@msujew msujew added filesystem issues related to the filesystem plug-in system issues related to the plug-in system bug bugs found in the application labels May 6, 2024
@jfaltermeier jfaltermeier added this to the 1.51.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application filesystem issues related to the filesystem plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants