-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spurious Failures in download:plugins
#13902
Comments
With some more logging, we're getting, for example "Server returned code 503." ("server unavailable"). In local testing I've also seen 429 ("too many requests"). Could be the server is just overloaded. |
Here are some more findings:
I can't really make out a pattern here: the errors seem to happen totally randomly. |
Attempted mitigation for #13902 - do not eat exceptions and properly log errors - reduces request rate to 3/sec. Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
The CI build jobs seem to be fixed after reducing the rate limit via CLI parameter to 3/sec. As for the 503's, there does seem to be some problem on the ovsx side: EclipseFdn/open-vsx.org#2752 |
Bug Description:
Currently, a lot of our CI jobs fail during the
yarn download:plugin
task. I was able to debug this a bit and it seems that when we request the plugin metadata for a uri like `https://open-vsx.org/api/v2/-/query?extensionId=vscode.go&includeAllVersions=true&targetPlatform=universal&offset=0', we get an error thrown (which is unfortunately eaten silently). The stack trace is:A typical scenario where this might happen is when a write occurs to the request after
request.end()
has been called. Another possibility is a timeout on the request, but we don't set a timeout on the request 🤷. Unfortunately, the problem comes and goes, so debugging is hard.The text was updated successfully, but these errors were encountered: